Review main Merged

72137[TASK] Enable Content-Security-Policy in backend acceptance tests

Oliver Hader CR +2 V +2 Easy +19 −11 updated 11/29/21, 21:52

Commit message

To avoid introducing new components that rely on inline JavaScript,
Content-Security-Policy HTTP headers for the TYPO3 backend are enabled
when executing automated tests.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Benni Mack +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 2130

Show 35 earlier messages
  1. Oliver Hader uploaded patch set 1 11/10/21, 09:25

  2. Oliver Hader marked it work in progress 11/10/21, 09:36

  3. core-ci voted on patch set 1 V -1 11/10/21, 09:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19116

  4. Oliver Hader rebased onto patch set 2 11/15/21, 20:38

  5. core-ci voted on patch set 2 V -1 11/15/21, 20:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19327

  1. Georg Ringer commented on patch set 2 11/16/21, 18:39

    isn't that a perfect example for a feature toggle?
  2. Oliver Hader rebased onto patch set 3 11/16/21, 18:54

  3. Oliver Hader commented on patch set 3 11/16/21, 18:56

    Reply

    Unfortunately not (yet), since there's so much more to CSP. For the time being I'd be happy in case nobody introduces new inline JavaScript - that happened during TYPO3 v11 development unfortunately...
  4. Oliver Hader updated the commit message in patch set 4 11/16/21, 18:56

  5. core-ci voted on patch set 3 V -1 11/16/21, 19:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19370

  6. core-ci voted on patch set 4 V -1 11/16/21, 19:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19371

  7. Oliver Hader commented on patch set 4 11/16/21, 19:18

  8. Oliver Hader rebased onto patch set 5 11/23/21, 13:27

  9. core-ci voted on patch set 5 V -1 11/23/21, 13:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19675

  10. Benni Mack wrote 11/29/21, 10:20

    Change destination moved from master to main
  11. Benni Mack updated the commit message in patch set 6 11/29/21, 14:10

  12. core-ci voted on patch set 6 V -1 11/29/21, 18:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20114

  13. Oliver Hader uploaded patch set 7 11/29/21, 20:08

  14. Oliver Hader commented on patch set 7 11/29/21, 20:10

    This change is ready for review.
  15. core-ci voted on patch set 7 V +1 11/29/21, 20:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20155

  16. Oliver Hader marked it work in progress 11/29/21, 20:34

  17. Oliver Hader uploaded patch set 8 11/29/21, 20:37

  18. Oliver Hader uploaded patch set 9 11/29/21, 20:39

  19. Oliver Hader commented on patch set 8 11/29/21, 20:46

    This change is ready for review.
    Proof it works with CSP violation at https://git.typo3.org/typo3/CI/cms/-/jobs/783800
  20. Oliver Hader marked it ready for review 11/29/21, 20:46

  21. core-ci voted on patch set 8 V -1 11/29/21, 20:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20158

  22. core-ci voted on patch set 9 V +1 11/29/21, 20:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20159

  23. Benni Mack voted on patch set 9 V +1 CR +1 11/29/21, 21:52

  24. Oliver Hader voted on patch set 9 V +2 CR +2 11/29/21, 21:52

  25. Oliver Hader merged patch set 10 11/29/21, 21:52