72138[BUGFIX] Fix undefined key warnings in MagicImageService
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Robert Kärner +1
- Benni Mack +1
-
Verified V +2 Done
- Oli Bartsch +2
- Robert Kärner +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 1
Review log 810
-
Robert Kärner uploaded patch set 1 11/10/21, 14:55
-
core-ci voted on patch set 1 V +1 11/10/21, 15:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19125
-
Oliver Klee voted on patch set 1 CR +1 11/10/21, 16:28
-
Oli Bartsch commented on patch set 1 11/10/21, 16:43
-
Benni Mack commented on patch set 2 11/10/21, 20:04
Published edit on patch set 1. -
core-ci voted on patch set 2 V +1 11/10/21, 20:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19149
-
Robert Kärner commented on patch set 2 V +1 CR +1 11/10/21, 20:24
MagicImageService.php:79Reply UnresolvedI agree, this sounds more reasonable. But now that Benni has pushed a new patchset, I wouldn‘t push another one, as long as you are happy with his solution too. -
Benni Mack voted on patch set 2 V +1 CR +1 11/10/21, 21:18
-
Oli Bartsch voted on patch set 2 V +2 CR +2 11/11/21, 11:12
-
Oli Bartsch merged patch set 3 11/11/21, 11:13
MagicImageService.php:79