Review main Merged

72140[BUGFIX] Make toolbar dropdown menu scrollable

Oli Bartsch CR +2 V +2 Easy +3 −1 updated 11/10/21, 17:37

Commit message

The contents of the toolbar dropdown menus
for bookmarks and open documents are dynamic.
Having e.g. a lot bookmarks previously lead to
the most recent bookmarks might be cut of at
the bottom of the screen.

This is now fixed by using a maximum height
and allowing vertical scroll.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Andreas Kienast +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1013

  1. Oli Bartsch uploaded patch set 1 11/10/21, 15:40

  2. core-ci voted on patch set 1 V +1 11/10/21, 15:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19127

  3. Benni Mack commented on patch set 1 V +1 CR +1 11/10/21, 16:22

    Thank you!
  4. Andreas Kienast voted on patch set 1 V +2 CR +2 11/10/21, 17:16

  5. Andreas Kienast commented on patch set 1 V 0 CR -1 11/10/21, 17:17

    This renders now an always visible scroll bar, I'll check this.
  6. Andreas Kienast rebased onto patch set 2 11/10/21, 17:18

  7. Andreas Kienast uploaded patch set 3 11/10/21, 17:18

  8. Andreas Kienast voted on patch set 3 V +1 CR +1 11/10/21, 17:19

  9. core-ci voted on patch set 2 V +1 11/10/21, 17:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19132

  10. core-ci voted on patch set 3 V +1 11/10/21, 17:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19133

  11. Benni Mack voted on patch set 3 V +1 CR +1 11/10/21, 17:34

  12. Oli Bartsch voted on patch set 3 V +2 CR +2 11/10/21, 17:37

  13. Oli Bartsch merged patch set 4 11/10/21, 17:37