Review main Merged

72151[TASK] Tighten tests and extend PHP 8.1 testing

Stefan Bürk CR +2 V +2 Normal +238 −11 updated 11/15/21, 14:52

Commit message

The big win with this patch: All core now run tests with E_ALL
error handling (unit, functional, acceptance). This means, they
will also fail when PHP deprecations are raised. This improves
PHP compatibility and makes sure new PHP versions can be integrated
more quickly since we'll find deprecated PHP code calls early.

Additionally, the acceptance tests are extended to run with PHP 8.1.
As a result, the entire testing is now done with PHP 8.1 and green,
we can claim PHP 8.1 compatibility for core now.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 9

Review log 4073

Show 2548 earlier messages
  1. Stefan Bürk uploaded patch set 1 11/10/21, 19:21

  2. core-ci voted on patch set 1 V -1 11/10/21, 19:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19145

  3. Stefan Bürk uploaded patch set 2 11/10/21, 19:46

  4. core-ci voted on patch set 2 V -1 11/10/21, 19:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19147

  5. Stefan Bürk uploaded patch set 3 11/10/21, 23:47

  6. core-ci voted on patch set 3 V +1 11/11/21, 00:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19162

  7. Stefan Bürk commented on patch set 3 CR -1 11/11/21, 00:01

    Just preparing / testing around. Running nightly now: https://git.typo3.org/typo3/CI/cms/-/pipelines/19163
  8. core-ci voted on patch set 3 V -1 11/11/21, 00:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19163

  9. Stefan Bürk uploaded patch set 4 11/11/21, 22:37

  10. core-ci voted on patch set 4 V +1 11/11/21, 22:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19195

  11. Stefan Bürk voted on patch set 4 CR -1 11/11/21, 22:53

  12. Stefan Bürk uploaded patch set 5 11/13/21, 19:59

  13. Stefan Bürk commented on patch set 5 CR -1 11/13/21, 20:03

    'doctrine/dbal' raise was merged as single patch. Last patchset removes dbal raise from this patch and rebased on that. Still missing: - typo3fluid/fluid: Merges of PR from Christian + new release tag + raise in core - typo3/testing-framework: new release tag + raise in core
  14. core-ci voted on patch set 5 V +1 11/13/21, 20:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19233

  15. Stefan Bürk uploaded patch set 6 11/13/21, 20:18

  16. Stefan Bürk voted on patch set 6 CR -1 11/13/21, 20:19

  17. core-ci voted on patch set 6 V +1 11/13/21, 20:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19234

  18. core-ci voted on patch set 6 V -1 11/13/21, 20:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19235

  19. Stefan Bürk uploaded patch set 7 11/13/21, 21:06

  20. core-ci voted on patch set 7 V +1 11/13/21, 21:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19236

  21. Stefan Bürk voted on patch set 7 CR -1 11/13/21, 21:20

  22. core-ci voted on patch set 7 V -1 11/13/21, 21:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19237

  23. Stefan Bürk uploaded patch set 8 11/13/21, 21:37

  24. Stefan Bürk voted on patch set 8 CR -1 11/13/21, 21:37

  25. core-ci voted on patch set 8 V -1 11/13/21, 21:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19240

  26. core-ci voted on patch set 8 V +1 11/13/21, 21:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19239

  27. Stefan Bürk uploaded patch set 9 11/13/21, 21:57

  28. Stefan Bürk voted on patch set 9 CR -1 11/13/21, 21:58

  29. core-ci voted on patch set 9 V +1 11/13/21, 22:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19241

  30. core-ci voted on patch set 9 V -1 11/13/21, 22:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19242

  31. Stefan Bürk uploaded patch set 10 11/13/21, 22:22

  32. Stefan Bürk voted on patch set 10 CR -1 11/13/21, 22:23

  33. core-ci voted on patch set 10 V -1 11/13/21, 22:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19244

  34. core-ci voted on patch set 10 V +1 11/13/21, 22:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19243

  35. Stefan Bürk uploaded patch set 11 11/13/21, 23:20

  36. Stefan Bürk voted on patch set 11 CR -1 11/13/21, 23:20

  37. core-ci voted on patch set 11 V -1 11/13/21, 23:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19246

  38. core-ci voted on patch set 11 V +1 11/13/21, 23:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19245

  39. Stefan Bürk uploaded patch set 12 11/13/21, 23:45

  40. Stefan Bürk voted on patch set 12 CR -1 11/13/21, 23:50

  41. core-ci voted on patch set 12 V +1 11/13/21, 23:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19247

  42. Stefan Bürk uploaded patch set 13 11/14/21, 00:23

  43. Stefan Bürk voted on patch set 13 CR -1 11/14/21, 00:23

  44. core-ci voted on patch set 12 V -1 11/14/21, 00:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19248

  45. core-ci voted on patch set 13 V +1 11/14/21, 00:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19249

  46. core-ci voted on patch set 12 V -1 11/14/21, 00:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19248

  47. Stefan Bürk uploaded patch set 14 11/14/21, 00:54

  48. core-ci voted on patch set 14 V +1 11/14/21, 01:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19250

  1. Stefan Bürk voted on patch set 14 CR -1 11/14/21, 01:08

  2. core-ci voted on patch set 14 V -1 11/14/21, 02:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19252

  3. Stefan Bürk uploaded patch set 15 11/14/21, 02:24

  4. Stefan Bürk voted on patch set 15 CR -1 11/14/21, 02:24

  5. core-ci voted on patch set 15 V +1 11/14/21, 02:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19254

  6. core-ci commented on patch set 15 11/14/21, 03:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19255

  7. Christian Kuhn uploaded patch set 16 11/15/21, 11:41

  8. Christian Kuhn uploaded patch set 17 11/15/21, 11:43

  9. Christian Kuhn uploaded patch set 18 11/15/21, 11:49

  10. core-ci voted on patch set 18 V +1 11/15/21, 12:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19289

  11. core-ci voted on patch set 16 V -1 11/15/21, 12:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19286

  12. core-ci voted on patch set 17 V +1 11/15/21, 12:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19287

  13. core-ci voted on patch set 18 V -1 11/15/21, 12:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19292

  14. core-ci voted on patch set 18 V +1 11/15/21, 13:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19292

  15. Stefan Bürk uploaded patch set 19 11/15/21, 13:51

  16. core-ci voted on patch set 19 V +1 11/15/21, 14:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19301

  17. Christian Kuhn commented on patch set 19 V +2 CR -1 11/15/21, 14:41

    waiting for nightly to finish.
  18. Christian Kuhn voted on patch set 19 CR -2 11/15/21, 14:41

  19. Anja Leichsenring voted on patch set 19 V +1 CR +1 11/15/21, 14:46

  20. core-ci commented on patch set 19 11/15/21, 14:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19302

  21. Jochen Roth voted on patch set 19 V +1 CR +1 11/15/21, 14:49

  22. Benni Mack voted on patch set 19 V +1 CR +1 11/15/21, 14:51

  23. Stefan Bürk voted on patch set 19 V +1 CR +1 11/15/21, 14:52

  24. Christian Kuhn voted on patch set 19 CR +2 11/15/21, 14:52

  25. Christian Kuhn merged patch set 20 11/15/21, 14:52