72153[TASK] Transform JavaScriptHandler.js to be hybrid IIFE and AMD
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Markus Klein +1
-
Verified V +2 Done
- Benni Mack +2
- Markus Klein +1
- core-ci +1 CI
Issues 1
Files 7
- Build/types/TYPO3/index.d.ts+14 −0
- typo3/sysext/core/Classes/Page/JavaScriptItems.phpnew+80 −0
- typo3/sysext/core/Classes/Page/JavaScriptModuleInstruction.php+1 −0
- typo3/sysext/core/Classes/Page/JavaScriptRenderer.php+9 −31
- typo3/sysext/core/Resources/Public/JavaScript/JavaScriptHandler.js+159 −122
- typo3/sysext/core/Tests/Functional/Page/JavaScriptRendererTest.php+1 −1
- typo3/sysext/core/Tests/Functional/Page/PageRendererTest.php+1 −1
Review log 68
-
Oliver Hader uploaded patch set 1 11/10/21, 20:33
-
core-ci voted on patch set 1 V +1 11/10/21, 20:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19150
-
Stephan Großberndt updated the commit message in patch set 2 11/10/21, 22:09
-
core-ci voted on patch set 2 V +1 11/10/21, 22:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19157
-
Benni Mack voted on patch set 2 V +1 CR +1 11/11/21, 08:39
-
Markus Klein voted on patch set 2 V +1 CR +1 11/11/21, 11:44
-
Benni Mack voted on patch set 2 V +2 CR +2 11/11/21, 14:22
-
Benni Mack merged patch set 3 11/11/21, 14:22