Review main Merged

72153[TASK] Transform JavaScriptHandler.js to be hybrid IIFE and AMD

Oliver Hader CR +2 V +2 Hard +265 −155 updated 11/11/21, 14:22

Commit message

With this change JavaScriptHandler.js is not only an immediately
invoked function expression (IIFE) like before but is extended to
be used as asynchronous module definition (AMD) as well. This way
it can be used in internal TypeScript implementations as well.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Markus Klein +1
  • Verified V +2 Done
    • Benni Mack +2
    • Markus Klein +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 68

  1. Oliver Hader uploaded patch set 1 11/10/21, 20:33

  2. core-ci voted on patch set 1 V +1 11/10/21, 20:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19150

  3. Stephan Großberndt updated the commit message in patch set 2 11/10/21, 22:09

  4. core-ci voted on patch set 2 V +1 11/10/21, 22:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19157

  5. Benni Mack voted on patch set 2 V +1 CR +1 11/11/21, 08:39

  6. Markus Klein voted on patch set 2 V +1 CR +1 11/11/21, 11:44

  7. Benni Mack voted on patch set 2 V +2 CR +2 11/11/21, 14:22

  8. Benni Mack merged patch set 3 11/11/21, 14:22