72154[TASK] Reduce inline JavaScript in FormEngine AJAX responses
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Nikita Hovratov +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- core-ci +1 CI
Issues 1
Files 18
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/FormEngine/InlineRelation/AjaxDispatcher.ts2+8 −2
- Build/Sources/TypeScript/redirects/Resources/Public/TypeScript/FormEngineEvaluation.tsnew+34 −0
- Build/types/TYPO3/index.d.ts+1 −0
- typo3/sysext/backend/Classes/Controller/AbstractFormEngineAjaxController.php+15 −1
- typo3/sysext/backend/Classes/Controller/FormFlexAjaxController.php+8 −15
- typo3/sysext/backend/Classes/Controller/FormInlineAjaxController.php+20 −13
- typo3/sysext/backend/Classes/Controller/SiteInlineAjaxController.php+11 −13
- typo3/sysext/backend/Classes/Form/Element/CustomEvaluationTrait.phpnew+52 −0
- typo3/sysext/backend/Classes/Form/Element/InputColorPickerElement.php+3 −5
- typo3/sysext/backend/Classes/Form/Element/InputLinkElement.php+2 −4
- typo3/sysext/backend/Classes/Form/Element/InputTextElement.php+2 −4
- typo3/sysext/backend/Classes/Form/Element/SelectMultipleSideBySideElement.php+1 −0
- typo3/sysext/backend/Classes/Form/AbstractNode.php+2 −0
- typo3/sysext/backend/Classes/Form/FormResultCompiler.php+2 −0
- typo3/sysext/backend/Resources/Public/JavaScript/FormEngine/InlineRelation/AjaxDispatcher.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/FormEngineValidation.js+21 −2
- typo3/sysext/redirects/Classes/Evaluation/SourceHost.php+10 −10
- typo3/sysext/redirects/Resources/Public/JavaScript/FormEngineEvaluation.jsnew+13 −0
Review log 811
-
Oliver Hader uploaded patch set 1 11/10/21, 20:33
-
core-ci voted on patch set 1 V +1 11/10/21, 20:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19151
-
Oliver Hader rebased onto patch set 2 11/11/21, 15:10
-
core-ci voted on patch set 2 V +1 11/11/21, 15:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19186
-
Oliver Hader uploaded patch set 3 11/15/21, 16:50
-
core-ci voted on patch set 3 V +1 11/15/21, 17:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19309
-
Nikita Hovratov commented on patch set 3 CR +1 11/15/21, 18:53
code-wise everything looks fine -
Oli Bartsch commented on patch set 3 V +1 CR +1 11/15/21, 20:18
AjaxDispatcher.ts:16Any specific reason for lowerCamelCase? -
Benni Mack voted on patch set 3 V +2 CR +2 11/15/21, 20:21
-
Benni Mack merged patch set 4 11/15/21, 20:22
-
Oliver Hader commented on patch set 4 11/15/21, 20:37
AjaxDispatcher.ts:16Reply Unresolvedstarting lower-case, since it's an instance of JavaScriptHandler, not the class declaration.