Review main Merged

72154[TASK] Reduce inline JavaScript in FormEngine AJAX responses

Oliver Hader CR +2 V +2 Hard +206 −70 updated 11/15/21, 20:37

Commit message

Reduces amount of `requireJsModules` and `scriptCall` invocations
in AJAX response handling and migrates to new `scriptItems` which
is forwarded to JavaScriptHandler.js.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 18

Review log 811

  1. Oliver Hader uploaded patch set 1 11/10/21, 20:33

  2. core-ci voted on patch set 1 V +1 11/10/21, 20:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19151

  3. Oliver Hader rebased onto patch set 2 11/11/21, 15:10

  4. core-ci voted on patch set 2 V +1 11/11/21, 15:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19186

  5. Oliver Hader uploaded patch set 3 11/15/21, 16:50

  6. core-ci voted on patch set 3 V +1 11/15/21, 17:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19309

  7. Nikita Hovratov commented on patch set 3 CR +1 11/15/21, 18:53

    code-wise everything looks fine
  8. Oli Bartsch commented on patch set 3 V +1 CR +1 11/15/21, 20:18

    AjaxDispatcher.ts:16

    Any specific reason for lowerCamelCase?
  9. Benni Mack voted on patch set 3 V +2 CR +2 11/15/21, 20:21

  10. Benni Mack merged patch set 4 11/15/21, 20:22

  11. Oliver Hader commented on patch set 4 11/15/21, 20:37

    AjaxDispatcher.ts:16 Reply Unresolved

    starting lower-case, since it's an instance of JavaScriptHandler, not the class declaration.