Review main Merged

72158[BUGFIX] Ensure TranslateViewHelper does not fail on invalid extension

Simon Gilli CR +2 V +2 Easy +13 −1 updated 11/12/21, 16:45

Commit message

Change #95839 introduced a regression that causes TranslateViewHelper
to fail when an invalid extension key is specified. This patch restores
the previous behavior and avoids more regressions by a new test.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Nikita Hovratov +1
    • Helmut Hummel +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Nikita Hovratov +1
    • Helmut Hummel +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 2028

Show 3 earlier messages
  1. Simon Gilli uploaded patch set 1 11/11/21, 12:54

  2. Simon Gilli commented on patch set 1 11/11/21, 13:03

    PS1 is expected to fail, TDD
  3. Simon Gilli uploaded patch set 2 11/11/21, 13:06

  1. core-ci voted on patch set 1 V -1 11/11/21, 13:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19171

  2. core-ci voted on patch set 2 V -1 11/11/21, 13:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19175

  3. Simon Gilli rebased onto patch set 3 11/11/21, 13:36

  4. core-ci voted on patch set 3 V -1 11/11/21, 13:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19177

  5. Simon Gilli uploaded patch set 4 11/11/21, 14:00

  6. Simon Gilli uploaded patch set 5 11/11/21, 14:00

  7. Simon Gilli uploaded patch set 6 11/11/21, 14:01

  8. Simon Gilli commented on patch set 6 11/11/21, 14:02

    Restart from scratch, sth went wrong. PS6 is expected to fail again, TDD.
  9. core-ci voted on patch set 4 V -1 11/11/21, 14:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19178

  10. core-ci voted on patch set 5 V -1 11/11/21, 14:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19179

  11. core-ci voted on patch set 6 V -1 11/11/21, 14:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19180

  12. Simon Gilli uploaded patch set 7 11/11/21, 14:24

  13. Simon Gilli commented on patch set 7 11/11/21, 14:27

    This change is ready for review.
    @Georg in PS6 you see the failure you had. PS7 finally fixes the regression.
  14. core-ci voted on patch set 7 V +1 11/11/21, 14:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19184

  15. Nikita Hovratov voted on patch set 7 V +1 CR +1 11/11/21, 16:23

  16. Helmut Hummel commented on patch set 7 11/11/21, 17:18

    LanguageStore.php:178

    how about throwing the FileNotFoundException here then instead of relying on it being thrown later on?
  17. Simon Gilli commented on patch set 7 11/11/21, 17:26

    LanguageStore.php:178 Reply

    My idea is to let it throw here but also catch UnknownPackagePathException in the LocalizationFactory instead.
  18. Georg Ringer commented on patch set 7 V +1 CR +1 11/11/21, 17:55

    works now again, thx!
  19. Simon Gilli uploaded patch set 8 11/11/21, 20:36

  20. Simon Gilli commented on patch set 8 11/11/21, 20:39

    LanguageStore.php:178 Reply

    Changed now to also catch the second exception. This is the shortest path to the point we like to get, the catch block in the LocalizationFactory.
  21. core-ci voted on patch set 8 V +1 11/11/21, 20:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19193

  22. Helmut Hummel voted on patch set 8 V +1 CR +1 11/12/21, 16:21

  23. Nikita Hovratov voted on patch set 8 V +1 CR +1 11/12/21, 16:27

  24. Georg Ringer voted on patch set 8 V +2 CR +2 11/12/21, 16:45

  25. Georg Ringer merged patch set 9 11/12/21, 16:45