72158[BUGFIX] Ensure TranslateViewHelper does not fail on invalid extension
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Nikita Hovratov +1
- Helmut Hummel +1
-
Verified V +2 Done
- Georg Ringer +2
- Nikita Hovratov +1
- Helmut Hummel +1
- core-ci +1 CI
Issues 1
Files 2
Review log 2028
Show 3 earlier messages
-
core-ci voted on patch set 1 V -1 11/11/21, 13:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19171
-
core-ci voted on patch set 2 V -1 11/11/21, 13:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19175
-
Simon Gilli rebased onto patch set 3 11/11/21, 13:36
-
core-ci voted on patch set 3 V -1 11/11/21, 13:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19177
-
Simon Gilli uploaded patch set 4 11/11/21, 14:00
-
Simon Gilli uploaded patch set 5 11/11/21, 14:00
-
Simon Gilli uploaded patch set 6 11/11/21, 14:01
-
Simon Gilli commented on patch set 6 11/11/21, 14:02
Restart from scratch, sth went wrong. PS6 is expected to fail again, TDD. -
core-ci voted on patch set 4 V -1 11/11/21, 14:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19178
-
core-ci voted on patch set 5 V -1 11/11/21, 14:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19179
-
core-ci voted on patch set 6 V -1 11/11/21, 14:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19180
-
Simon Gilli uploaded patch set 7 11/11/21, 14:24
-
Simon Gilli commented on patch set 7 11/11/21, 14:27
This change is ready for review.@Georg in PS6 you see the failure you had. PS7 finally fixes the regression. -
core-ci voted on patch set 7 V +1 11/11/21, 14:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19184
-
Nikita Hovratov voted on patch set 7 V +1 CR +1 11/11/21, 16:23
-
Helmut Hummel commented on patch set 7 11/11/21, 17:18
LanguageStore.php:178how about throwing the FileNotFoundException here then instead of relying on it being thrown later on? -
Simon Gilli commented on patch set 7 11/11/21, 17:26
LanguageStore.php:178ReplyMy idea is to let it throw here but also catch UnknownPackagePathException in the LocalizationFactory instead. -
Georg Ringer commented on patch set 7 V +1 CR +1 11/11/21, 17:55
works now again, thx! -
Simon Gilli uploaded patch set 8 11/11/21, 20:36
-
Simon Gilli commented on patch set 8 11/11/21, 20:39
LanguageStore.php:178ReplyChanged now to also catch the second exception. This is the shortest path to the point we like to get, the catch block in the LocalizationFactory. -
core-ci voted on patch set 8 V +1 11/11/21, 20:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19193
-
Helmut Hummel voted on patch set 8 V +1 CR +1 11/12/21, 16:21
-
Nikita Hovratov voted on patch set 8 V +1 CR +1 11/12/21, 16:27
-
Georg Ringer voted on patch set 8 V +2 CR +2 11/12/21, 16:45
-
Georg Ringer merged patch set 9 11/12/21, 16:45