Review main Abandoned

72160[FEATURE] Provide an actual replacement for the ExtTablesPostProcessingHooks

Oliver Eglseder CR 0 V 0 Normal +76 −3 updated 11/11/22, 16:08

Commit message

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 4

Review log 1417

  1. Oliver Eglseder uploaded patch set 1 11/12/21, 09:51

  2. core-ci voted on patch set 1 V +1 11/12/21, 10:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19199

  3. Chris Müller commented on patch set 1 CR -1 11/12/21, 19:04

    I think, at least an RST is needed to announce the new event.
  4. Lina Wolf commented on patch set 1 CR -1 11/13/21, 09:39

    Working on it
  5. Lina Wolf commented on patch set 1 11/13/21, 10:03

    I believe a new Event is always a feature. A new Event needs a changelog Entry. The hook can still be used in version 11. This seems to be a rare usecase following this discussion: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70834/4/typo3/sysext/core/Classes/Core/Bootstrap.php
  6. Lina Wolf commented on patch set 1 11/13/21, 10:07

    This should be a feature

    ExtTablesPostProcessingEvent.php:21 Unresolved

    The doc comment should describe when this Event is called and what it can be used for. It should not be explained by referencing a deprecated hook.
  7. Benni Mack wrote 11/29/21, 10:14

    Change destination moved from master to main
  8. Benni Mack updated the commit message in patch set 2 11/29/21, 13:38

  9. Oliver Eglseder uploaded patch set 3 12/01/21, 11:38

  10. core-ci voted on patch set 3 V +1 12/01/21, 11:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20304

  11. Chris Müller updated the commit message in patch set 4 12/01/21, 17:43

  12. Chris Müller commented on patch set 4 12/01/21, 17:44

    As this is a feature and only goes to main, the feature RST should be stored in 12.0 folder instead of 11.5.x.
  13. core-ci voted on patch set 4 V +1 12/01/21, 17:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20348

  14. Helmut Hummel commented on patch set 4 CR -2 12/08/21, 13:24

    I'll block this change for now until the use case is given in the bug report on forge. The use case is very important, because there is no reliable place when ext_tables are exactly included. It differs from BE, FE (without BE user), FE (with BE user), CLI, install tool So any addition should be approached with looking at the exact use case
  15. Oliver Eglseder commented on patch set 4 12/10/21, 11:20

    Reply Unresolved

    Updated

    Reply Unresolved

    Is there any way and guideline how to get this into 11.5.x?
  16. Lina Wolf wrote 12/10/21, 11:26

    Removed reviewer Lina Wolf.
  17. Benni Mack abandoned the change 11/11/22, 16:08

    as discussed, you've found a workaround for v11, and module registration API is new in v12 (during boot time), so nothing needed to be done here.