Review main Merged

72161[BUGFIX] Raise doctrine/dbal:^2.13.5

Stefan Bürk CR +2 V +2 Easy +14 −14 updated 11/12/21, 20:00

Commit message

doctrine/dbal driver for postgres has been feeding null to
preg_match() in some constellations, which emits E_DEPRECATED
warning in PHP8.1 with E_ALL. doctrine/dbal:2.13.5 includes
the bugfix for this issue and more.

This patch acts as pre-patch to activate E_ALL and more PHP81
testing and thus raise the min version to ^2.13.5 to avoid these
warnings and make functional tests for postgres with E_ALL happy.

Used composer commands:

composer req doctrine/dbal:^2.13.5
composer req doctrine/dbal:^2.13.5 -d typo3/sysext/core --no-update
composer req doctrine/dbal:^2.13.5 -d typo3/sysext/install --no-update
composer req doctrine/dbal:^2.13.5 -d typo3/sysext/redirects --no-update

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Simon Gilli +1
    • Anja Leichsenring +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Benni Mack +2
    • Simon Gilli +1
    • Anja Leichsenring +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1116

  1. Stefan Bürk uploaded patch set 1 11/12/21, 10:57

  2. Stefan Bürk updated the commit message in patch set 2 11/12/21, 10:58

  3. core-ci voted on patch set 1 V +1 11/12/21, 11:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19201

  4. core-ci voted on patch set 2 V -1 11/12/21, 11:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19202

  5. core-ci voted on patch set 2 V +1 11/12/21, 11:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19202

  6. Stefan Bürk commented on patch set 2 CR -1 11/12/21, 11:27

    Torture with nightly. pre-merge -1 was acceptance hickup.
  7. core-ci commented on patch set 2 11/12/21, 12:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19206

  8. Stefan Bürk updated the commit message in patch set 3 11/12/21, 14:33

  9. Stefan Bürk commented on patch set 3 11/12/21, 14:35

    Pipeline 19206 (nighlty) was happy.
  10. core-ci voted on patch set 3 V +1 11/12/21, 14:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19210

  11. Anja Leichsenring voted on patch set 3 V +1 CR +1 11/12/21, 16:36

  12. Nikita Hovratov voted on patch set 3 V +1 CR +1 11/12/21, 16:45

  13. Oliver Klee voted on patch set 3 CR +1 11/12/21, 17:04

  14. Simon Gilli voted on patch set 3 V +1 CR +1 11/12/21, 17:19

  15. Benni Mack voted on patch set 3 V +2 CR +2 11/12/21, 20:00

  16. Benni Mack merged patch set 4 11/12/21, 20:00