72162[TASK] Add correct test for shortcut issue in language menu
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oliver Klee +1
- Stefan Bürk +1
-
Verified V +2 Done
- Benni Mack +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 3
Files 3
- typo3/sysext/frontend/Tests/Functional/SiteHandling/LocalizedPageRendering/Fixtures/ScenarioD.yaml+1 −0
- typo3/sysext/frontend/Tests/Functional/SiteHandling/LocalizedPageRendering/AbstractLocalizedPagesTestCase.php3+19 −0
- typo3/sysext/frontend/Tests/Functional/SiteHandling/LocalizedPageRendering/ScenarioDTest.php3+15 −0
Review log 1215
-
Nikita Hovratov uploaded patch set 1 11/12/21, 13:25
-
core-ci voted on patch set 1 V +1 11/12/21, 13:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19207
-
Oliver Klee commented on patch set 1 11/12/21, 14:01
ScenarioDTest.php:199Let's make the test method name a statement about the expected behavior (including a verb :-) ). My suggestion: languageMenuHasLanguageShortcutsWithLanguageSpecificUrls -
Nikita Hovratov commented on patch set 1 11/12/21, 14:14
AbstractLocalizedPagesTestCase.php:155ReplyCan't do that because of $this references. What we can do is, to not call phpunits assert within this function and just return the resultScenarioDTest.php:199ReplySounds good :) -
Nikita Hovratov uploaded patch set 2 11/12/21, 14:19
-
Nikita Hovratov commented on patch set 1 11/12/21, 14:20
AbstractLocalizedPagesTestCase.php:155ReplyDoneScenarioDTest.php:199ReplyDone -
Oliver Klee commented on patch set 2 CR +1 11/12/21, 14:24
Neat! -
Nikita Hovratov updated the commit message in patch set 3 11/12/21, 14:29
-
Nikita Hovratov commented on patch set 3 11/12/21, 14:30
Adjusted the commit message, please revote. -
core-ci voted on patch set 2 V +1 11/12/21, 14:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19208
-
Oliver Klee voted on patch set 3 CR +1 11/12/21, 14:41
-
core-ci voted on patch set 3 V +1 11/12/21, 14:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19209
-
Stefan Bürk voted on patch set 3 V +1 CR +1 11/12/21, 15:14
-
Benni Mack voted on patch set 3 V +2 CR +2 11/12/21, 22:54
-
Benni Mack merged patch set 4 11/12/21, 22:54
AbstractLocalizedPagesTestCase.php:155