72163[BUGFIX] Resolve page id correctly in ConditionMatcher
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Kevin Appelt +1
-
Verified V +2 Done
- Benni Mack +2
- Kevin Appelt +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1619
-
Nicole Hummel uploaded patch set 1 11/12/21, 15:37
-
core-ci voted on patch set 1 V +1 11/12/21, 15:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19211
-
Kevin Appelt commented on patch set 1 V +1 CR +1 11/12/21, 16:04
After applying the patch, content elements can be moved again with NullBackend used. -
Oliver Klee commented on patch set 1 11/12/21, 17:05
Can we cover this bug with a regression test? -
Jan Helke commented on patch set 1 V +1 CR +1 11/14/21, 09:23
I would be happy to have this in the next release even without the regression test. -
Oliver Hader commented on patch set 1 11/15/21, 09:33
ConditionMatcher.php:113Fixing the type issue seems to be fine...ConditionMatcher.php:120Where is the sub-key `'target'` coming from? From reading it means, `$target` can be either * `$target = 123` or * `$target['target'] = 123` -
Oliver Hader commented on patch set 1 11/15/21, 10:08
ConditionMatcher.php:120ReplyLooks like this is set here (for Drag'n'Drop): https://github.com/TYPO3/typo3/blob/v11.5.2/Build/Sources/TypeScript/backend/Resources/Public/TypeScript/LayoutModule/DragDrop.ts#L207 -
Benni Mack uploaded patch set 2 11/15/21, 10:14
-
Benni Mack voted on patch set 2 V +1 CR +1 11/15/21, 10:14
-
core-ci voted on patch set 2 V +1 11/15/21, 10:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19282
-
Oliver Hader commented on patch set 2 11/15/21, 10:33
ConditionMatcher.php:119In DataHandler it is used as `$value['action'] === 'paste'`, so I guess it should be `($actionAndTarget['action'] ?? '') === 'paste'` instead? -
Nicole Hummel commented on patch set 2 11/15/21, 10:40
ConditionMatcher.php:119ReplyAFAIK the action for "paste" is always called "move" in cmdMap, this means this change is useless.ConditionMatcher.php:120ReplyI don't know where it comes from, but in the tests I was able to trigger the needed target id is defined in $target['target']. I'm not sure if there are any other scenarios where $target is set as id so I decided to fallback to the old usecase. -
Benni Mack uploaded patch set 3 11/15/21, 11:05
-
core-ci voted on patch set 3 V +1 11/15/21, 11:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19284
-
Benni Mack voted on patch set 3 V +1 CR +1 11/15/21, 17:35
-
Kevin Appelt voted on patch set 3 V +1 CR +1 11/15/21, 19:12
-
Benni Mack voted on patch set 3 V +2 CR +2 11/15/21, 19:27
-
Benni Mack merged patch set 4 11/15/21, 19:27
-
Benni Mack commented on patch set 4 11/15/21, 19:27
ConditionMatcher.php:113ReplyDoneConditionMatcher.php:119ReplyDoneConditionMatcher.php:120ReplyDone