Review main Merged

72165[TASK] Extract ext:test_irre_csv from ext:irre_tutorial

Anja Leichsenring CR +2 V +2 Nightmare +3115 −2992 updated 11/15/21, 12:26

Commit message

For easier testing, ext:irre_tutorial "csv" setup
is extracted to a dedicated extension.
Tests concerning these tables can now load the smaller
test extension, which reduces system load and simplifies
maintenance.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 164

Show 144 more files

Review log 1016

  1. Anja Leichsenring uploaded patch set 1 11/13/21, 15:11

  2. core-ci voted on patch set 1 V -1 11/13/21, 15:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19228

  3. Anja Leichsenring uploaded patch set 2 11/14/21, 09:34

  4. Anja Leichsenring updated the commit message in patch set 3 11/14/21, 09:34

  5. core-ci voted on patch set 3 V -1 11/14/21, 09:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19258

  6. core-ci voted on patch set 2 V -1 11/14/21, 09:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19257

  7. Anja Leichsenring uploaded patch set 4 11/14/21, 09:39

  8. core-ci voted on patch set 4 V +1 11/14/21, 09:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19259

  9. Stefan Bürk commented on patch set 4 11/15/21, 11:43

    Thanks Anja for the patch and the work. Some minor comments after the first look-through. Commit message looks a little bit out of format.

    ext_tables.sql:9

    Should we not remove the commata, as it is the only/last field (to be consistent with other table definitions)

    ext_tables.sql:2

    Should we not change this here to 'irrecsv' oder 'testirrecsv' ? Not sure if I'm getting in right, but otherwies all these 1ncsv namings were changed through these extraction. Or should this still describe that 1:n behaviour, which is done directly after ?

    JsonRenderer.typoscript:20

    Wrong indentation ? (not really visible in PHPStorm, seems there to be the same)
  10. Christian Kuhn commented on patch set 4 11/15/21, 11:57

    ext_tables.sql:9 Reply

    nah.

    ext_tables.sql:2 Reply

    cosmetical. there will be another change which can change this.

    JsonRenderer.typoscript:20 Reply

    next patch will extract this.
  11. core-ci commented on patch set 4 11/15/21, 12:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19285

  12. Christian Kuhn uploaded patch set 5 11/15/21, 12:06

  13. Stefan Bürk voted on patch set 5 V +1 CR +1 11/15/21, 12:09

  14. core-ci voted on patch set 5 V +1 11/15/21, 12:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19291

  15. Christian Kuhn voted on patch set 5 V +2 CR +2 11/15/21, 12:26

  16. Christian Kuhn merged patch set 6 11/15/21, 12:26