Review main Merged

72166[BUGFIX] Raise 3rd party composer packages to composer.lock version

Stefan Bürk CR +2 V +2 Normal +102 −100 updated 11/15/21, 11:31

Commit message

During testing to activate E_ALL and PHP 8.1 testing with activated
E_ALL, nightly 'composerMin' tests for PHP8.1 are failing with several
E_DEPRECATED warnings, which was not discoverd in composerLock tests.

Several composer packages, ex. 'symfony/finder' and 'symfony/routing',
are required with different min versions than written in composer.lock
file, thus downgrading these components which emits E_DEPRECATED PHP8.1
warnings in nightly composerMin tests execeuted with PHP 8.1.

'symfony/options-resolver' needs to be added directly, as this has been
installed as dependency with different lower version constraints for
'friendsofphp/php-cs-fixer' and 'symfony/rate-limiter', thus we need to
add it directly with the locked version as min requirement as there are
no newer versions of these packages with needed min version as required
version.

'bacon/bacon-qr-code' needs to be raised to avoid a float to int PHP8.1
conversion warning.

This patch acts as pre-patch to activate E_ALL and PHP 8.1 testing and
thus raise version of these components to the currently locked version
in 'composer.lock' file, to be conservative.

Used composer commands:

composer req bacon/bacon-qr-code:^2.0.4
composer req bacon/bacon-qr-code:^2.0.4 \
  -d typo3/sysext/core --no-update

composer req masterminds/html5:^2.7.5
composer req masterminds/html5:^2.7.5 \
  -d typo3/sysext/core --no-update

composer req symfony/config:^5.3.4
composer req symfony/config:^5.3.4 \
  -d typo3/sysext/core --no-update

composer req symfony/console:^5.3.7
composer req symfony/console:^5.3.7 \
  -d typo3/sysext/core --no-update
composer req symfony/console:^5.3.7 \
  -d typo3/sysext/redirects --no-update

composer req symfony/dependency-injection:^5.3.7
composer req symfony/dependency-injection:^5.3.7 \
  -d typo3/sysext/core --no-update
composer req symfony/dependency-injection:^5.3.7 \
  -d typo3/sysext/extbase --no-update
composer req symfony/dependency-injection:^5.3.7 \
  -d typo3/sysext/fluid --no-update

composer req symfony/expression-language:^5.3.7
composer req symfony/expression-language:^5.3.7 \
  -d typo3/sysext/core --no-update
composer req symfony/expression-language:^5.3.7 \
  -d typo3/sysext/form --no-update

composer req symfony/filesystem:^5.3.4
composer req symfony/filesystem:^5.3.4 \
  -d typo3/sysext/core --no-update

composer req symfony/finder:^5.3.7
composer req symfony/finder:^5.3.7 \
  -d typo3/sysext/core --no-update
composer req symfony/finder:^5.3.7 \
  -d typo3/sysext/install --no-update

composer req symfony/http-foundation:^5.3.7
composer req symfony/http-foundation:^5.3.7 \
  -d typo3/sysext/core --no-update
composer req symfony/http-foundation:^5.3.7 \
  -d typo3/sysext/install --no-update

composer req symfony/mailer:^5.3.4
composer req symfony/mailer:^5.3.4 \
  -d typo3/sysext/core --no-update

composer req symfony/mime:^5.3.7
composer req symfony/mime:^5.3.7 \
  -d typo3/sysext/core --no-update

composer req symfony/polyfill-intl-normalizer:^1.23.0
composer req symfony/polyfill-intl-normalizer:^1.23.0 \
  -d typo3/sysext/core --no-update

composer req symfony/polyfill-intl-icu:^1.23.0
composer req symfony/polyfill-intl-icu:^1.23.0 \
  -d typo3/sysext/core --no-update

composer req symfony/polyfill-intl-idn:^1.23.0
composer req symfony/polyfill-intl-idn:^1.23.0 \
  -d typo3/sysext/core --no-update

composer req symfony/polyfill-mbstring:^1.23.1
composer req symfony/polyfill-mbstring:^1.23.1 \
  -d typo3/sysext/core --no-update
composer req symfony/polyfill-mbstring:^1.23.1 \
  -d typo3/sysext/frontend --no-update

composer req symfony/property-access:^5.3.7
composer req symfony/property-access:^5.3.7 \
  -d typo3/sysext/extbase --no-update

composer req symfony/property-info:^5.3.7
composer req symfony/property-info:^5.3.7 \
  -d typo3/sysext/extbase --no-update

composer req symfony/rate-limiter:^5.3.4
composer req symfony/rate-limiter:^5.3.4 \
  -d typo3/sysext/core --no-update

composer req symfony/routing:^5.3.7
composer req symfony/routing:^5.3.7 \
  -d typo3/sysext/core --no-update

composer req symfony/var-dumper:^5.3.7
composer req symfony/var-dumper:^5.3.7 \
  -d typo3/sysext/adminpanel --no-update

composer req symfony/yaml:^5.3.6
composer req symfony/yaml:^5.3.6 \
 -d typo3/sysext/core --no-update

Following are needed, but are new as direct requirements but locked:

composer req symfony/options-resolver:^5.3.7
composer req symfony/options-resolver:^5.3.7 \
  -d typo3/sysext/core --no-update

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 10

Review log 1115

  1. Stefan Bürk uploaded patch set 1 11/14/21, 10:48

  2. Stefan Bürk commented on patch set 1 CR -1 11/14/21, 10:51

    -1 temporarly to block. Let's torture nightly with it first.
  3. core-ci voted on patch set 1 V +1 11/14/21, 11:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19260

  4. core-ci voted on patch set 1 V -1 11/14/21, 11:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19261

  5. core-ci voted on patch set 1 V +1 11/14/21, 11:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19261

  6. Stefan Bürk updated the commit message in patch set 2 11/14/21, 12:02

  7. Stefan Bürk commented on patch set 2 CR -1 11/14/21, 12:03

    Nightly had a hickupg resolving git.typo3.org on git checkout in one test, retry solved it.
  8. core-ci voted on patch set 2 V +1 11/14/21, 12:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19267

  9. Christian Kuhn voted on patch set 2 V +1 CR +1 11/15/21, 10:12

  10. Stefan Bürk wrote 11/15/21, 10:14

    Removed Code-Review-1 by Stefan Bürk <stefan@buerk.tech>
  11. Christian Kuhn commented on patch set 2 11/15/21, 10:15

    Imho that's fine since we're raising patch level only.
  12. Oliver Klee voted on patch set 2 CR +1 11/15/21, 10:26

  13. Jochen Roth voted on patch set 2 V +1 CR +1 11/15/21, 11:29

  14. Christian Kuhn voted on patch set 2 V +2 CR +2 11/15/21, 11:31

  15. Christian Kuhn merged patch set 3 11/15/21, 11:31