Review main Merged

72168[BUGFIX] Ignore prefixParentPageSlug for non-page record in SlugHelper

Stefan Bürk CR +2 V +2 Easy +47 −1 updated 11/22/21, 15:50

Commit message

TCA slug field generator option 'prefixParentPageSlug' has been added
to be used for page records only. Slug generation for non-page records
with pid=0 has been fixed with #94655 which introduced a endless loop
if 'prefixParentPageSlug' is used as slug field generator option for
record tables.

This patch only process 'prefixParentPageSlug' for page records, thus
ignoring it for non-page records and avoiding the endlees loop and as
such prevent segmentation faults or memory_limit fatal errors.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1219

  1. Stefan Bürk uploaded patch set 1 11/14/21, 19:55

  2. core-ci voted on patch set 1 V -1 11/14/21, 20:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19273

  3. Stefan Bürk uploaded patch set 2 11/15/21, 19:28

  4. core-ci voted on patch set 2 V +1 11/15/21, 19:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19315

  5. Stefan Bürk uploaded patch set 3 11/15/21, 20:53

  6. core-ci voted on patch set 3 V +1 11/15/21, 21:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19328

  7. Stefan Bürk updated the commit message in patch set 4 11/15/21, 21:56

  8. core-ci voted on patch set 4 V +1 11/15/21, 22:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19340

  9. Stefan Bürk marked it ready for review 11/16/21, 13:27

  10. Stefan Bürk rebased onto patch set 5 11/16/21, 13:28

  11. core-ci voted on patch set 5 V +1 11/16/21, 13:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19361

  12. Benni Mack updated the commit message in patch set 6 11/18/21, 10:48

  13. core-ci voted on patch set 6 V +1 11/18/21, 12:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19478

  14. Benni Mack updated the commit message in patch set 7 11/18/21, 14:05

  15. Benni Mack voted on patch set 7 CR +1 11/18/21, 14:06

  16. core-ci voted on patch set 7 V +1 11/18/21, 14:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19513

  17. Benni Mack voted on patch set 7 V +1 11/22/21, 14:22

  18. Oli Bartsch voted on patch set 7 V +2 CR +2 11/22/21, 15:50

  19. Oli Bartsch merged patch set 8 11/22/21, 15:50