Review main Merged

72170[BUGFIX] Fix loose type check in BackendUserAuthentication

Benjamin Franzke CR +2 V +2 Easy +1 −4 updated 05/04/22, 06:38

Commit message

empty() returns true if a record contains 0 as value.
Therefore isset() needs to be used instead.

The corresponding fix that was introduced with #91145
to workaround this flaw is removed again.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Nikita Hovratov +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Nikita Hovratov +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 67

  1. Benjamin Franzke uploaded patch set 1 11/15/21, 09:34

  2. core-ci voted on patch set 1 V +1 11/15/21, 09:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19281

  3. Benni Mack voted on patch set 1 V +1 CR +1 11/15/21, 10:14

  4. Nikita Hovratov commented on patch set 1 V +1 CR +1 11/15/21, 15:54

    Nice, now I can see at least the root page as an editor with no rights.
  5. Benjamin Franzke voted on patch set 1 V +2 CR +2 11/15/21, 16:45

  6. Benjamin Franzke merged patch set 2 11/15/21, 16:45

  7. Oliver Hader commented on patch set 2 05/04/22, 06:38