Review main Merged

72172[BUGFIX] Use text-end instead of text-right

Benni Mack CR +2 V +2 Easy +16 −16 updated 11/15/21, 18:18

Commit message

Bootstrap 5 ships with "text-end" which is semantically
more correct than "text-right".

This change adapts the needed places in TYPO3 Core
to use "text-end".

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Nikita Hovratov +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Nikita Hovratov +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 13

Review log 1418

  1. Benni Mack uploaded patch set 1 11/15/21, 11:47

  2. core-ci voted on patch set 1 V +1 11/15/21, 12:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19288

  3. Nikita Hovratov uploaded patch set 2 11/15/21, 12:40

  4. core-ci voted on patch set 2 V +1 11/15/21, 12:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19295

  5. Nikita Hovratov uploaded patch set 3 11/15/21, 12:54

  6. Nikita Hovratov voted on patch set 3 V +1 CR +1 11/15/21, 12:55

  7. core-ci voted on patch set 3 V -1 11/15/21, 13:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19298

  8. Nikita Hovratov uploaded patch set 4 11/15/21, 14:25

  9. core-ci voted on patch set 4 V +1 11/15/21, 14:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19305

  10. Benni Mack commented on patch set 4 11/15/21, 16:08

    _module.scss:155

    I think we should keep both in the CSS definitions
  11. Nikita Hovratov commented on patch set 4 11/15/21, 16:20

    _module.scss:155 Reply

    Why?
  12. Benni Mack commented on patch set 4 11/15/21, 16:34

    _module.scss:155 Reply

    I hope nobody is using "text-right" in modules ... ;)
  13. Nikita Hovratov commented on patch set 4 11/15/21, 16:42

    _module.scss:155 Reply

    This is only used for the doc-header (For this path thing). As this is auto-generated, this should be fine I think.
  14. Benni Mack voted on patch set 4 V +1 CR +1 11/15/21, 17:34

  15. Benni Mack commented on patch set 4 11/15/21, 17:34

    _module.scss:155 Reply

    Ack
  16. Nikita Hovratov voted on patch set 4 V +1 CR +1 11/15/21, 17:54

  17. Oli Bartsch voted on patch set 4 V +2 CR +2 11/15/21, 18:18

  18. Oli Bartsch merged patch set 5 11/15/21, 18:18