Review main Merged

72181[BUGFIX] Define foreign_match_field definition for test setup

Anja Leichsenring CR +2 V +2 Expert +525 −520 updated 11/16/21, 10:54

Commit message

ext:irre_tutorial has two relations to tx_irretutorial_1nff_hotel
from tt_content: One from native field tx_irretutorial_1nff_hotels
and one from within flex for field tx_irretutorial_flexform.

With two relations in place, both need a foreign_match_fields
definition written to the child table to distinguish the two
relations. This is missing for tx_irretutorial_1nff_hotels and
leads to the situation that adding a relation to the flex field
is then shown as relation for the native field, too.

The patch adds a foreign_match_fields definition to the native
field and adapts the .csv test cases accordingly.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 140

Show 120 more files

Review log 811

  1. Anja Leichsenring uploaded patch set 1 11/15/21, 17:29

  2. core-ci voted on patch set 1 V +1 11/15/21, 17:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19310

  3. Christian Kuhn uploaded patch set 2 11/16/21, 10:30

  4. Christian Kuhn updated the commit message in patch set 3 11/16/21, 10:31

  5. Christian Kuhn voted on patch set 3 V +1 CR +1 11/16/21, 10:34

  6. core-ci voted on patch set 2 V +1 11/16/21, 10:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19350

  7. Jochen Roth voted on patch set 3 V +1 CR +1 11/16/21, 10:53

  8. core-ci voted on patch set 3 V +1 11/16/21, 10:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19351

  9. Oli Bartsch voted on patch set 3 V +1 CR +1 11/16/21, 10:54

  10. Oli Bartsch voted on patch set 3 V +2 CR +2 11/16/21, 10:54

  11. Oli Bartsch merged patch set 4 11/16/21, 10:54