72184[BUGFIX] Make external page error handling work again
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
- Oli Bartsch +1
- Christian Kuhn +1
-
Verified V +2 Done
- Oliver Hader +2
- Oli Bartsch +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 3
Files 1
Review log 1116
-
Benni Mack uploaded patch set 1 11/15/21, 20:13
-
Benni Mack updated the commit message in patch set 2 11/15/21, 20:16
-
Benni Mack commented on patch set 3 11/15/21, 20:21
Published edit on patch set 2. -
Benni Mack commented on patch set 4 11/15/21, 20:21
Published edit on patch set 3. -
core-ci voted on patch set 1 V -1 11/15/21, 20:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19319
-
Benni Mack uploaded patch set 5 11/15/21, 20:31
-
core-ci voted on patch set 3 V -1 11/15/21, 20:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19321
-
core-ci voted on patch set 2 V -1 11/15/21, 20:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19320
-
core-ci voted on patch set 4 V -1 11/15/21, 20:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19322
-
core-ci voted on patch set 5 V +1 11/15/21, 20:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19323
-
Oli Bartsch commented on patch set 5 11/15/21, 21:05
PageContentErrorHandler.php:162Could we use the PSR-17 factories instead? ResponseFactors e.g. is already present in this class. -
Benni Mack commented on patch set 5 11/15/21, 21:12
PageContentErrorHandler.php:162Replywe can't, because we cannot set "ALL" headers at once by using factories :( -
Oli Bartsch commented on patch set 5 V +1 CR +1 11/15/21, 21:42
PageContentErrorHandler.php:162ReplyAck -
Oliver Hader voted on patch set 5 V +2 CR +2 11/16/21, 09:06
-
Oliver Hader merged patch set 6 11/16/21, 09:06
-
Christian Kuhn voted on patch set 6 V +1 CR +1 11/16/21, 09:35