Review main Merged

72185[TASK] Avoid inline JavaScript in Scheduler

Oliver Hader CR +2 V +2 Normal +44 −28 updated 11/16/21, 17:36

Commit message

Schedule task "Table Garbage Collection" uses inline JavaScript
to declare default values for different database tables. Besides
that proper prototype functions instead of closures assigned to
properties are used - which require proper scoping with `bind()`.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Oli Bartsch +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 914

  1. Oliver Hader uploaded patch set 1 11/15/21, 22:01

  2. core-ci voted on patch set 1 V -1 11/15/21, 22:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19341

  3. Oliver Hader uploaded patch set 2 11/15/21, 22:30

  4. core-ci voted on patch set 2 V +1 11/15/21, 22:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19342

  5. Oliver Hader uploaded patch set 3 11/16/21, 08:03

  6. core-ci voted on patch set 3 V -1 11/16/21, 08:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19347

  7. Oliver Hader uploaded patch set 4 11/16/21, 10:49

  8. core-ci voted on patch set 3 V -1 11/16/21, 10:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19347

  9. core-ci voted on patch set 4 V +1 11/16/21, 11:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19353

  10. Oli Bartsch voted on patch set 4 V +1 CR +1 11/16/21, 12:38

  11. Stefan Bürk voted on patch set 4 V +1 CR +1 11/16/21, 13:36

  12. Oliver Hader voted on patch set 4 V +2 CR +2 11/16/21, 17:36

  13. Oliver Hader merged patch set 5 11/16/21, 17:36

  14. Oliver Hader commented on patch set 5 11/16/21, 17:36

    Thx for the reviews