Review main Merged

72190[BUGFIX] Fix undefined key warning in ContentObjectRenderer

Florian Rival CR +2 V +2 Easy +2 −2 updated 11/16/21, 21:30

Commit message

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Oliver Klee +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1418

  1. Florian Rival uploaded patch set 1 11/16/21, 11:34

  2. core-ci voted on patch set 1 V -1 11/16/21, 11:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19356

  3. Nikita Hovratov commented on patch set 1 11/16/21, 11:52

    ContentObjectRenderer.php:4608

    no need for parenthesis, thats why it fails.
  4. Florian Rival uploaded patch set 2 11/16/21, 12:22

  5. core-ci voted on patch set 2 V +1 11/16/21, 12:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19359

  6. Oli Bartsch commented on patch set 2 CR -1 11/16/21, 12:40

    ContentObjectRenderer.php:4608

    Default has to be a string, see @return type annotation.
  7. Florian Rival commented on patch set 2 11/16/21, 13:36

    ContentObjectRenderer.php:4608 Reply

    Yes you're right, I'll check if it's OK with an empty string. I've set the same value returned when running with PHP 7.
  8. Florian Rival uploaded patch set 3 11/16/21, 13:41

  9. core-ci voted on patch set 3 V +1 11/16/21, 13:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19363

  10. Nikita Hovratov voted on patch set 3 CR +1 11/16/21, 13:55

  11. Florian Rival commented on patch set 3 11/16/21, 14:19

    ContentObjectRenderer.php:4608 Reply

    Done

    ContentObjectRenderer.php:4608 Reply

    Done
  12. Oliver Klee voted on patch set 3 CR +1 11/16/21, 15:17

  13. Nikita Hovratov uploaded patch set 4 11/16/21, 18:09

  14. Nikita Hovratov commented on patch set 4 V +1 CR +1 11/16/21, 18:10

    Now the case is also covered, when slideBack is true.
  15. core-ci voted on patch set 4 V +1 11/16/21, 18:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19368

  16. Oliver Klee voted on patch set 4 CR +1 11/16/21, 20:08

  17. Oli Bartsch voted on patch set 4 V +2 CR +2 11/16/21, 21:30

  18. Oli Bartsch merged patch set 5 11/16/21, 21:30