Review main Merged

72192[BUGFIX] Fix undefined array key warnings in field providers

Oli Bartsch CR +2 V +2 Easy +5 −5 updated 11/16/21, 18:38

Commit message

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Stefan Bürk +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1012

  1. Oli Bartsch uploaded patch set 1 11/16/21, 12:12

  2. core-ci voted on patch set 1 V +1 11/16/21, 12:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19358

  3. Stefan Bürk voted on patch set 1 V +1 CR +1 11/16/21, 13:39

  4. Oliver Klee commented on patch set 1 11/16/21, 16:14

    SchedulerModuleController.php:548

    We're accessing $this->submittedData['uid'] multiple times in this method. I propose we move this (including the fallback to 0) into a local variable $uid.
  5. Oli Bartsch uploaded patch set 2 11/16/21, 17:40

  6. Oli Bartsch commented on patch set 2 11/16/21, 17:42

    SchedulerModuleController.php:548 Reply

    Since I'm no longer able to reproduce this, basically because this property should already be set in mainAction, I reverted those changes in the last patchset.
  7. Nikita Hovratov voted on patch set 2 V +1 CR +1 11/16/21, 17:46

  8. Stefan Bürk voted on patch set 2 V +1 CR +1 11/16/21, 17:47

  9. Oliver Klee voted on patch set 2 CR +1 11/16/21, 17:49

  10. core-ci voted on patch set 2 V +1 11/16/21, 17:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19365

  11. Georg Ringer voted on patch set 2 V +2 CR +2 11/16/21, 18:38

  12. Georg Ringer merged patch set 3 11/16/21, 18:38