72193[BUGFIX] Save correct table name as ref_table in refindex
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 1011
-
Henrik Ziegenhain uploaded patch set 1 11/16/21, 12:44
-
Nikita Hovratov commented on patch set 1 11/16/21, 19:02
Hey, we didn't plan to backport it to v10. The regular maintenance has ended a short while ago. And if we would do so, it has to be backported by a core merger. I don't know, what the procedure would be so let's wait for another opinion on that. -
Benni Mack commented on patch set 1 11/16/21, 20:24
SoftReferenceIndex.php:439that's kinda a breaking change... we require this public method in a non-internal class to now need to have three method arguments. -
Henrik Ziegenhain commented on patch set 1 11/17/21, 05:58
SoftReferenceIndex.php:439ReplyThanks for your Review. As Nikita said, you did not plan to backport it to v10. So we must abandonate this, even if this method is only called from one place in core? -
Nikita Hovratov commented on patch set 1 11/17/21, 08:42
SoftReferenceIndex.php:439ReplyMaybe we can store referenceTable and referenceUid as private properties of SoftReferenceIndex. Then we can remove the parameters. -
Nikita Hovratov uploaded patch set 2 11/17/21, 09:03
-
Nikita Hovratov commented on patch set 2 11/17/21, 09:04
SoftReferenceIndex.php:439ReplyDone -
Nikita Hovratov commented on patch set 2 11/17/21, 09:12
Created a new patch here https://review.typo3.org/c/Packages/TYPO3.CMS/+/72202 which references the original patch. -
core-ci voted on patch set 2 V +1 11/17/21, 09:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19391
-
Oli Bartsch commented on patch set 2 11/17/21, 12:57
Hi Henrik, could you please abandon this patch in favor of https://review.typo3.org/c/Packages/TYPO3.CMS/+/72202? -
Henrik Ziegenhain abandoned the change 11/17/21, 13:23
Abandoned in favor of https://review.typo3.org/c/Packages/TYPO3.CMS/+/72202