Review 10.4 Abandoned

72193[BUGFIX] Save correct table name as ref_table in refindex

Henrik Ziegenhain CR 0 V 0 Easy +26 −1 updated 11/17/21, 13:23

Commit message

The identifier from the linkHandler page TSconfig was formerly used as
the reference table name "ref_table". This identifier is free to choose
and shouldn't be interpreted as a name of a table.

In order to resolve the correct table name, which is stated in the
configuration, the page id of the reference record is now used. This
allows the TypolinkSoftReferenceParser to read the according page
TSconfig and to set the correct table name.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 1011

  1. Henrik Ziegenhain uploaded patch set 1 11/16/21, 12:44

  2. Nikita Hovratov commented on patch set 1 11/16/21, 19:02

    Hey, we didn't plan to backport it to v10. The regular maintenance has ended a short while ago. And if we would do so, it has to be backported by a core merger. I don't know, what the procedure would be so let's wait for another opinion on that.
  3. Benni Mack commented on patch set 1 11/16/21, 20:24

    SoftReferenceIndex.php:439

    that's kinda a breaking change... we require this public method in a non-internal class to now need to have three method arguments.
  4. Henrik Ziegenhain commented on patch set 1 11/17/21, 05:58

    SoftReferenceIndex.php:439 Reply

    Thanks for your Review. As Nikita said, you did not plan to backport it to v10. So we must abandonate this, even if this method is only called from one place in core?
  5. Nikita Hovratov commented on patch set 1 11/17/21, 08:42

    SoftReferenceIndex.php:439 Reply

    Maybe we can store referenceTable and referenceUid as private properties of SoftReferenceIndex. Then we can remove the parameters.
  6. Nikita Hovratov uploaded patch set 2 11/17/21, 09:03

  7. Nikita Hovratov commented on patch set 2 11/17/21, 09:04

    SoftReferenceIndex.php:439 Reply

    Done
  8. Nikita Hovratov commented on patch set 2 11/17/21, 09:12

    Created a new patch here https://review.typo3.org/c/Packages/TYPO3.CMS/+/72202 which references the original patch.
  9. core-ci voted on patch set 2 V +1 11/17/21, 09:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19391

  10. Oli Bartsch commented on patch set 2 11/17/21, 12:57

    Hi Henrik, could you please abandon this patch in favor of https://review.typo3.org/c/Packages/TYPO3.CMS/+/72202?
  11. Henrik Ziegenhain abandoned the change 11/17/21, 13:23