Review main Merged

72194[TASK] runTests.sh: xdebug trigger works with macOS and WSL2

Simon Gilli CR +2 V +2 Normal +65 −43 updated 11/17/21, 18:24

Commit message

docker on mac and windows WSL2 encapsulate a VM into
the system. The current xdebug remote config does not
work in those cases since the host IP can not be
determined with the current solution.

Switching to host.docker.internal works for macOS
and WSL2, and works for linux too in combination with
an extra_hosts setting.

This requires linux to use at least docker 20.10,
which shouldn't be a huge issue with casual developer
machines.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Simon Gilli +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Simon Gilli +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1015

  1. Simon Gilli uploaded patch set 1 11/16/21, 17:17

  2. core-ci voted on patch set 1 V -1 11/16/21, 17:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19364

  3. Christian Kuhn rebased onto patch set 2 11/17/21, 15:11

  4. core-ci voted on patch set 2 V -1 11/17/21, 15:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19408

  5. Christian Kuhn uploaded patch set 3 11/17/21, 15:45

  6. core-ci voted on patch set 3 V -1 11/17/21, 16:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19410

  7. core-ci voted on patch set 3 V +1 11/17/21, 16:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19410

  8. Christian Kuhn uploaded patch set 4 11/17/21, 17:53

  9. Christian Kuhn updated the commit message in patch set 5 11/17/21, 17:55

  10. Oliver Hader marked it ready for review 11/17/21, 18:07

  11. core-ci voted on patch set 5 V +1 11/17/21, 18:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19420

  12. Stefan Bürk voted on patch set 5 V +1 CR +1 11/17/21, 18:19

  13. Simon Gilli voted on patch set 5 V +1 CR +1 11/17/21, 18:23

  14. Christian Kuhn voted on patch set 5 V +2 CR +2 11/17/21, 18:24

  15. Christian Kuhn merged patch set 6 11/17/21, 18:24