Review main Merged

72197[BUGFIX] Fix linkvalidator level

Sybille Peters CR +2 V +2 Easy +2 −2 updated 11/17/21, 13:36

Commit message

Fix a problem in the GUI where the previous page "depth" selector
("Show this level") was not remembered when selecting a different
page in the page tree.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1214

  1. Sybille Peters uploaded patch set 1 11/16/21, 21:31

  2. Sybille Peters wrote 11/16/21, 21:34

    Topic set to Linkvalidator
  3. core-ci voted on patch set 1 V +1 11/16/21, 21:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19382

  4. Oli Bartsch commented on patch set 1 11/16/21, 22:05

    LinkValidatorReport.php:220

    Personally I think "-1" always looks a bit odd in this context. Couldn't we just restore the "?? 0" fallback and simply remove the isset? if ($this->searchLevel[$prefix]) would then also evaluate to false.
  5. Sybille Peters commented on patch set 1 11/16/21, 22:36

    LinkValidatorReport.php:220 Reply

    I would have to check - I think the problem is if it is not set and we just default to 0 we cannot differentiate between it REALLY should be 0 and it is just 0 because it is not set - in which case we should load the default from the MOD_SETTINGS. IMHO it is more clear that way: -1 really means undefined, whereas 0 means set level=0.
  6. Oli Bartsch commented on patch set 1 11/16/21, 22:46

    LinkValidatorReport.php:220 Reply

    Oke, but in this case I suggest to fall back to NULL and strictly check for this. According to docs, this is the correct fallback: > The special null value represents a variable with no value. null is the only possible value of type null.
  7. Sybille Peters uploaded patch set 2 11/16/21, 23:08

  8. core-ci voted on patch set 2 V +1 11/16/21, 23:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19385

  9. Tymoteusz Motylewski commented on patch set 2 11/17/21, 00:06

    is this issue only v11 or does it exists in v10 too?
  10. Sybille Peters commented on patch set 2 11/17/21, 06:32

    Reply

    No, I cannot reproduce this with latest v10.
  11. Sybille Peters commented on patch set 2 11/17/21, 06:33

    LinkValidatorReport.php:220 Reply

    Done
  12. Benni Mack voted on patch set 2 V +1 CR +1 11/17/21, 08:16

  13. Oli Bartsch voted on patch set 2 V +2 CR +2 11/17/21, 13:36

  14. Oli Bartsch merged patch set 3 11/17/21, 13:36