72197[BUGFIX] Fix linkvalidator level
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Benni Mack +1
-
Verified V +2 Done
- Oli Bartsch +2
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1214
-
Sybille Peters uploaded patch set 1 11/16/21, 21:31
-
Sybille Peters wrote 11/16/21, 21:34
Topic set to Linkvalidator -
core-ci voted on patch set 1 V +1 11/16/21, 21:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19382
-
Oli Bartsch commented on patch set 1 11/16/21, 22:05
LinkValidatorReport.php:220Personally I think "-1" always looks a bit odd in this context. Couldn't we just restore the "?? 0" fallback and simply remove the isset? if ($this->searchLevel[$prefix]) would then also evaluate to false. -
Sybille Peters commented on patch set 1 11/16/21, 22:36
LinkValidatorReport.php:220ReplyI would have to check - I think the problem is if it is not set and we just default to 0 we cannot differentiate between it REALLY should be 0 and it is just 0 because it is not set - in which case we should load the default from the MOD_SETTINGS. IMHO it is more clear that way: -1 really means undefined, whereas 0 means set level=0. -
Oli Bartsch commented on patch set 1 11/16/21, 22:46
LinkValidatorReport.php:220ReplyOke, but in this case I suggest to fall back to NULL and strictly check for this. According to docs, this is the correct fallback: > The special null value represents a variable with no value. null is the only possible value of type null. -
Sybille Peters uploaded patch set 2 11/16/21, 23:08
-
core-ci voted on patch set 2 V +1 11/16/21, 23:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19385
-
Tymoteusz Motylewski commented on patch set 2 11/17/21, 00:06
is this issue only v11 or does it exists in v10 too? -
Sybille Peters commented on patch set 2 11/17/21, 06:32
Reply
No, I cannot reproduce this with latest v10. -
Sybille Peters commented on patch set 2 11/17/21, 06:33
LinkValidatorReport.php:220ReplyDone -
Benni Mack voted on patch set 2 V +1 CR +1 11/17/21, 08:16
-
Oli Bartsch voted on patch set 2 V +2 CR +2 11/17/21, 13:36
-
Oli Bartsch merged patch set 3 11/17/21, 13:36