72199[FEATURE] Allow tagging of data processors
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Georg Ringer +1
- Benni Mack +1
-
Verified V +2 Done
- Oli Bartsch +2
- Jonas Eberle +1
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 7
- typo3/sysext/core/Documentation/Changelog/12.1/Feature-96005-AllowTaggingandAliasingOfDataProcessors.rstnew+85 −0
- typo3/sysext/frontend/Classes/ContentObject/ContentDataProcessor.php+7 −6
- typo3/sysext/frontend/Classes/DataProcessing/DataProcessorRegistry.php2new+50 −0
- typo3/sysext/frontend/Configuration/Services.yaml2+47 −4
- typo3/sysext/frontend/Tests/Unit/ContentObject/ContentDataProcessorTest.php+8 −1
- typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php+5 −1
- typo3/sysext/frontend/Tests/Unit/ContentObject/FluidTemplateContentObjectTest.php+5 −1
Review log 4359
Show 2234 earlier messages
-
Thomas Löffler uploaded patch set 1 11/16/21, 21:40
-
core-ci voted on patch set 1 V +1 11/16/21, 21:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19384
-
Thomas Löffler updated the commit message in patch set 2 11/17/21, 06:48
-
core-ci voted on patch set 2 V +1 11/17/21, 07:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19388
-
Thomas Löffler updated the commit message in patch set 3 11/18/21, 12:21
-
core-ci voted on patch set 3 V +1 11/18/21, 12:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19504
-
Benni Mack wrote 11/29/21, 10:21
Change destination moved from master to main -
Benni Mack updated the commit message in patch set 4 11/29/21, 14:10
-
core-ci voted on patch set 4 V +1 11/29/21, 17:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20108
-
Benni Mack commented on patch set 4 01/14/22, 12:26
OK, if we make a feature out of it? -
Thomas Löffler uploaded patch set 5 08/11/22, 20:33
-
Thomas Löffler uploaded patch set 6 08/11/22, 20:34
-
Thomas Löffler updated the commit message in patch set 7 08/11/22, 20:35
-
Thomas Löffler commented on patch set 6 08/11/22, 20:35
Reply
Sure. And done. -
core-ci voted on patch set 6 V +1 08/11/22, 20:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30053
-
core-ci voted on patch set 7 V +1 08/11/22, 20:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30054
-
core-ci voted on patch set 5 V +1 08/11/22, 20:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30052
-
Chris Müller commented on patch set 7 CR -1 08/12/22, 08:25
As this is a feature we need a feature RST. Also the releases line in the commit message should only contain "main". -
Thomas Löffler uploaded patch set 8 08/12/22, 21:39
-
core-ci voted on patch set 8 V +1 08/12/22, 21:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30130
-
Chris Müller uploaded patch set 9 08/13/22, 18:22
-
Chris Müller uploaded patch set 10 08/13/22, 18:23
-
core-ci voted on patch set 9 V +1 08/13/22, 18:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30151
-
core-ci voted on patch set 10 V +1 08/13/22, 18:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30152
-
Chris Müller commented on patch set 10 08/13/22, 18:35
This does not work for me: page.30 = FLUIDTEMPLATE page.30 { // ... dataProcessing.10 = dataProcessor.siteLanguage dataProcessing.10 { as = language } } Produces the error: Processor class or service name "dataProcessor.siteLanguage" does not exist! Do I miss something? Cleared the DI cache, of course. -
Thomas Löffler commented on patch set 10 08/13/22, 21:54
Reply
Will check. -
Thomas Löffler commented on patch set 10 08/13/22, 22:27
Reply
Using not the shortcut syntax and public: true works for me now. -
Thomas Löffler uploaded patch set 11 08/13/22, 22:27
-
core-ci voted on patch set 11 V +1 08/13/22, 22:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30153
-
Chris Müller uploaded patch set 12 08/14/22, 07:35
-
Chris Müller commented on patch set 12 08/14/22, 07:37
Thomas, please check before pushing for new patchsets. I updated the doc yesterday. Pushed it again now. -
Chris Müller commented on patch set 12 V +1 CR +1 08/14/22, 07:38
Reply
Done -
core-ci voted on patch set 12 V +1 08/14/22, 07:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30158
-
Thomas Löffler commented on patch set 12 08/14/22, 08:54
Reply
Sorry.
-
Christian Kuhn updated the commit message in patch set 13 08/19/22, 08:18
-
core-ci voted on patch set 13 V +1 08/19/22, 08:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30293
-
Thomas Löffler voted on patch set 13 V +1 CR +1 08/19/22, 08:28
-
Chris Müller voted on patch set 13 V +1 CR +1 08/19/22, 13:03
-
Jonas Eberle voted on patch set 13 V +1 CR +1 09/12/22, 16:05
-
Benjamin Franzke commented on patch set 13 09/20/22, 07:12
How about an alternative syntax, using DI tags as we use for similar cases as well: Example: TYPO3\CMS\Frontend\DataProcessing\CommaSeparatedValueProcessor tags: - { name: 'data-processor', identifier: 'comma-separated-value' } Which then allows to use `dataProcessing.20 = comma-separated-value` in TypoScript. Benefits: * In line with other cases like console commands * `public: true` becomes implicits * Typing FQDN vs aliases is basically and provides no *real* technical benifit, its just short (yes, that a bonus for sure) * We could read all available data-processors from DI thanks to tags (e.g. for future modules) and present them in a backend module for developers to look at (like we have for middlewares). -
Benjamin Franzke wrote 09/20/22, 07:13
Topic set to di -
Oli Bartsch commented on patch set 13 09/22/22, 07:55
Reply
+1 for using this approach. -
Oli Bartsch uploaded patch set 14 10/18/22, 22:42
-
Oli Bartsch commented on patch set 14 10/18/22, 22:51
Reply
Done. See https://review.typo3.org/c/Packages/TYPO3.CMS/+/76162 for migration in core. -
core-ci voted on patch set 14 V -1 10/18/22, 22:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32446
-
Oli Bartsch uploaded patch set 15 10/18/22, 23:09
-
core-ci voted on patch set 15 V +1 10/18/22, 23:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32448
-
Benjamin Franzke commented on patch set 15 10/19/22, 03:43
Thanks Oli, looks good so far. Only some minor remarks.DataProcessorRegistry.php:29Maybe be explicit and use Symfony\Component\DependencyInjection\ServiceLocator. (Makes it clear that we could also use $dataProcessorLocator->getProvidedServices() to get a list of tags, e.g. for introspection in backend-configuration-module).Services.php:19Hm, thanks to the tagged_locator, we actually don't need `setPublic(true)`, because symfony makes the private serivces available to the tagged-locator. So this would only make sense for services that were already marked public. Thefefor I'd say: Let's rather define `public: true` in Services (MenuProcessor) where needed for BC, and drop it here. I would even like if we set `shared: false` only where actually needed (MenuProcessor, GalleryProcessor, LanguageMenuProcessor from what I see).Services.yaml:32public not needed -
Oli Bartsch uploaded patch set 16 10/19/22, 07:56
-
Oli Bartsch commented on patch set 16 10/19/22, 07:58
DataProcessorRegistry.php:29ReplyDoneServices.php:19ReplyDoneServices.yaml:32ReplyDone -
core-ci voted on patch set 16 V +1 10/19/22, 08:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32458
-
Benni Mack voted on patch set 16 CR +1 10/19/22, 09:34
-
Benni Mack voted on patch set 16 V +1 10/19/22, 09:44
-
Georg Ringer voted on patch set 16 CR +1 10/19/22, 10:30
-
Jonas Eberle commented on patch set 16 V -1 10/20/22, 07:24
I've found images not being displayed when used with https://review.typo3.org/c/Packages/TYPO3.CMS/+/76162 CType: textmedia field: assets (added 3 images) ``` tt_content.textmedia { templateName = Textmedia dataProcessing { 10 = files references.fieldName = assets } } } ``` The `files` variable is an empty array in the Fluid template. -
Oli Bartsch commented on patch set 16 10/20/22, 13:14
Reply
Good catch. This however is not related to this patch but was due to a bug in the other patch (see https://review.typo3.org/c/Packages/TYPO3.CMS/+/76162/1..2/typo3/sysext/fluid_styled_content/Configuration/TypoScript/ContentElement/Textmedia.typoscript). -
Jonas Eberle voted on patch set 16 V +1 10/20/22, 14:10
-
Oli Bartsch voted on patch set 16 V +2 CR +2 10/20/22, 14:21
-
Oli Bartsch merged patch set 17 10/20/22, 14:21