Review 10.4 Merged

72202[BUGFIX] Save correct table name as ref_table in refindex

Nikita Hovratov CR +2 V +2 Easy +26 −1 updated 11/17/21, 15:27

Commit message

The identifier from the linkHandler page TSconfig was formerly used as
the reference table name "ref_table". This identifier is free to choose
and shouldn't be interpreted as a name of a table.

In order to resolve the correct table name, which is stated in the
configuration, the page id of the reference record is now used. This
allows the TypolinkSoftReferenceParser to read the according page
TSconfig and to set the correct table name.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Henrik Ziegenhain +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Henrik Ziegenhain +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Nikita Hovratov uploaded patch set 1 11/17/21, 09:11

  2. core-ci voted on patch set 1 V +1 11/17/21, 09:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19392

  3. Oli Bartsch voted on patch set 1 V +1 CR +1 11/17/21, 12:52

  4. Henrik Ziegenhain voted on patch set 1 V +1 CR +1 11/17/21, 13:23

  5. Benni Mack voted on patch set 1 V +2 CR +2 11/17/21, 15:27

  6. Benni Mack merged patch set 2 11/17/21, 15:27