Review main Merged

72203[BUGFIX] Add missing field enclosure to example

Oli Bartsch CR +2 V +2 Easy +1 −1 updated 11/17/21, 15:34

Commit message

The example for the CommaSeparatedValueProcessor
was missing a value for the fieldEnclosure property.
This might lead to the assumption that this property
can be "unset", which is not the case as it always
defaults to a quotation mark (").

This is now fixed by adding an example value.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 36

  1. Oli Bartsch uploaded patch set 1 11/17/21, 11:40

  2. core-ci voted on patch set 1 V -1 11/17/21, 11:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19398

  3. core-ci commented on patch set 1 11/17/21, 12:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19398

  4. core-ci voted on patch set 1 V +1 11/17/21, 13:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19398

  5. Benni Mack voted on patch set 1 V +2 CR +2 11/17/21, 15:34

  6. Benni Mack merged patch set 2 11/17/21, 15:34