Review main Merged

72204[BUGFIX] Properly explode file collection uids as int

Oli Bartsch CR +2 V +2 Easy +1 −1 updated 11/17/21, 19:13

Commit message

The FilesProcessor previously exploded the comma
separated list of file collection uids with trimExplode.

However, the underlying FileCollector method
expects the uids to be of type int. Therefore, the
data processor now uses GU::intExplode(), like
already done in FileContentObject, instead.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Oliver Klee +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Oli Bartsch uploaded patch set 1 11/17/21, 11:48

  2. core-ci voted on patch set 1 V +1 11/17/21, 12:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19399

  3. Benni Mack voted on patch set 1 V +1 CR +1 11/17/21, 15:32

  4. Jochen Roth voted on patch set 1 V +1 CR +1 11/17/21, 18:43

  5. Oliver Klee voted on patch set 1 CR +1 11/17/21, 18:50

  6. Christian Kuhn voted on patch set 1 V +2 CR +2 11/17/21, 19:13

  7. Christian Kuhn merged patch set 2 11/17/21, 19:13