Review main Merged

72206[TASK] Avoid inline JavaScript in backend update signals

Oliver Hader CR +2 V +2 Normal +159 −13 updated 11/23/21, 09:57

Commit message

BackendUtility::getUpdateSignalCode() returned plain inline JavaScript
code which got replaced by new BackendUtility::getUpdateSignalDetails().

The new function is capable of handling inline JavaScript code (for
backward compatibility reasons) and HTML markup using corresponding
`<typo3-immediate-action>` custom element.

OpendocsToolbarItem::updateNumberOfOpenDocsHook has been adjusted as
well to use the script-less implementation.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • core-ci +1 CI

Issues 2

Files 11

Review log 1318

  1. Oliver Hader uploaded patch set 1 11/17/21, 12:50

  2. core-ci voted on patch set 1 V +1 11/17/21, 13:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19401

  3. Oliver Hader uploaded patch set 2 11/17/21, 13:40

  4. core-ci voted on patch set 2 V -1 11/17/21, 13:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19403

  5. Oliver Hader uploaded patch set 3 11/17/21, 15:47

  6. core-ci voted on patch set 3 V +1 11/17/21, 16:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19412

  7. Oliver Hader updated the commit message in patch set 4 11/18/21, 10:49

  8. core-ci voted on patch set 4 V +1 11/18/21, 12:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19481

  9. Benjamin Franzke commented on patch set 4 CR -1 11/19/21, 08:23

    DispatchNotificationHook.php:38

    Hm, this is not an equivalent replacement. This previous code ensured that TYPO3/CMS/Redirects/EventHandler has been fully loaded in the top frame. With the new code these two modules are loaded independent from each other (and EventHandler isn't loaded into the top frame). Tht means the event might be dispatched when TYPO3/CMS/Redirects/EventHandler has not yet been loaded. I think we need a designated action in ImmediateAction for this case. (Other than that this Patch would be CR+1 by me)
  10. Oliver Hader commented on patch set 4 11/19/21, 08:28

    DispatchNotificationHook.php:38 Reply

    Ack
  11. Oliver Hader uploaded patch set 5 11/19/21, 08:56

  12. Oliver Hader commented on patch set 5 11/19/21, 08:57

    DispatchNotificationHook.php:38 Reply

    I removed modifications from this change-set and will handle it in a different patch.
  13. core-ci voted on patch set 5 V +1 11/19/21, 09:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19544

  14. Oliver Hader commented on patch set 5 11/19/21, 09:35

    @bnf: I extracted the other part to https://review.typo3.org/c/Packages/TYPO3.CMS/+/72240
  15. Oli Bartsch commented on patch set 5 V +1 CR +1 11/22/21, 21:36

    OpendocsMenu.ts:52 Unresolved

    Seems to be unused
  16. Jochen Roth voted on patch set 5 V +1 CR +1 11/23/21, 09:12

  17. Oli Bartsch voted on patch set 5 V +2 CR +2 11/23/21, 09:57

  18. Oli Bartsch merged patch set 6 11/23/21, 09:57