72206[TASK] Avoid inline JavaScript in backend update signals
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Jochen Roth +1
-
Verified V +2 Done
- Oli Bartsch +2
- Jochen Roth +1
- core-ci +1 CI
Issues 2
Files 11
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/Element/ImmediateActionElement.ts+3 −0
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/Event/EventDispatcher.tsnew+26 −0
- Build/Sources/TypeScript/opendocs/Resources/Public/TypeScript/Toolbar/OpendocsMenu.ts1+4 −0
- typo3/sysext/backend/Classes/Domain/Model/Element/ImmediateActionElement.php+13 −0
- typo3/sysext/backend/Classes/Template/ModuleTemplate.php+14 −1
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+76 −4
- typo3/sysext/backend/Resources/Public/JavaScript/Element/ImmediateActionElement.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/Event/EventDispatcher.jsnew+13 −0
- typo3/sysext/opendocs/Classes/Backend/ToolbarItems/OpendocsToolbarItem.php+7 −6
- typo3/sysext/opendocs/Resources/Public/JavaScript/Toolbar/OpendocsMenu.js+1 −1
- typo3/sysext/redirects/Classes/Hooks/DispatchNotificationHook.php3+1 −0
Review log 1318
-
Oliver Hader uploaded patch set 1 11/17/21, 12:50
-
core-ci voted on patch set 1 V +1 11/17/21, 13:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19401
-
Oliver Hader uploaded patch set 2 11/17/21, 13:40
-
core-ci voted on patch set 2 V -1 11/17/21, 13:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19403
-
Oliver Hader uploaded patch set 3 11/17/21, 15:47
-
core-ci voted on patch set 3 V +1 11/17/21, 16:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19412
-
Oliver Hader updated the commit message in patch set 4 11/18/21, 10:49
-
core-ci voted on patch set 4 V +1 11/18/21, 12:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19481
-
Benjamin Franzke commented on patch set 4 CR -1 11/19/21, 08:23
-
Oliver Hader commented on patch set 4 11/19/21, 08:28
DispatchNotificationHook.php:38ReplyAck -
Oliver Hader uploaded patch set 5 11/19/21, 08:56
-
Oliver Hader commented on patch set 5 11/19/21, 08:57
DispatchNotificationHook.php:38ReplyI removed modifications from this change-set and will handle it in a different patch. -
core-ci voted on patch set 5 V +1 11/19/21, 09:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19544
-
Oliver Hader commented on patch set 5 11/19/21, 09:35
@bnf: I extracted the other part to https://review.typo3.org/c/Packages/TYPO3.CMS/+/72240 -
Oli Bartsch commented on patch set 5 V +1 CR +1 11/22/21, 21:36
OpendocsMenu.ts:52UnresolvedSeems to be unused -
Jochen Roth voted on patch set 5 V +1 CR +1 11/23/21, 09:12
-
Oli Bartsch voted on patch set 5 V +2 CR +2 11/23/21, 09:57
-
Oli Bartsch merged patch set 6 11/23/21, 09:57
DispatchNotificationHook.php:38