Review main Merged

72208[TASK] Extract ext:test_irre_foreignfield from ext:irre_tutorial

Anja Leichsenring CR +2 V +2 Impossible +6448 −6405 updated 11/21/21, 21:04

Commit message

For easier testing, ext:irre_tutorial "foreignfield" setup
is extracted to a dedicated extension.
Tests concerning these tables can now load the smaller
test extension, which reduces system load and simplifies
maintenance.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 211

Show 191 more files

Review log 2231

Show 46 earlier messages
  1. Anja Leichsenring uploaded patch set 1 11/17/21, 15:09

  2. Anja Leichsenring uploaded patch set 2 11/19/21, 09:08

  3. Anja Leichsenring wrote 11/19/21, 09:08

    Unset private
  4. core-ci voted on patch set 2 V +1 11/19/21, 09:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19545

  5. Anja Leichsenring updated the commit message in patch set 3 11/19/21, 09:59

  6. core-ci voted on patch set 3 V +1 11/19/21, 10:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19549

  1. Stefan Bürk voted on patch set 3 V +1 CR +1 11/19/21, 15:33

  2. Anja Leichsenring commented on patch set 3 CR -2 11/19/21, 19:49

    let me polish this some more
  3. Stefan Bürk wrote 11/19/21, 21:14

    Removed Verified+1 by Stefan Bürk <stefan@buerk.tech>
  4. Stefan Bürk wrote 11/19/21, 21:14

    Removed Code-Review+1 by Stefan Bürk <stefan@buerk.tech>
  5. Anja Leichsenring uploaded patch set 4 11/21/21, 09:48

  6. Anja Leichsenring commented on patch set 4 CR 0 11/21/21, 09:49

    clean separation now between ext:irre_tutorial and new ext:test_irre_foreignfield.
  7. core-ci voted on patch set 4 V -1 11/21/21, 09:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19596

  8. Anja Leichsenring uploaded patch set 5 11/21/21, 10:07

  9. Anja Leichsenring uploaded patch set 6 11/21/21, 10:10

  10. Anja Leichsenring uploaded patch set 7 11/21/21, 10:13

  11. Anja Leichsenring uploaded patch set 8 11/21/21, 10:19

  12. core-ci voted on patch set 5 V +1 11/21/21, 10:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19597

  13. core-ci voted on patch set 6 V -1 11/21/21, 10:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19598

  14. core-ci voted on patch set 7 V -1 11/21/21, 10:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19599

  15. Christian Kuhn commented on patch set 8 11/21/21, 10:36

    WorkspaceNewPlaceholderRemovalTest.php:45

    irre_tutorial can be removed here.
  16. core-ci voted on patch set 8 V -1 11/21/21, 10:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19600

  17. Christian Kuhn commented on patch set 8 11/21/21, 10:54

    WorkspaceNewPlaceholderRemovalTest.php:45 Reply

    Done
  18. Anja Leichsenring uploaded patch set 9 11/21/21, 10:55

  19. core-ci voted on patch set 9 V -1 11/21/21, 11:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19601

  20. Anja Leichsenring uploaded patch set 10 11/21/21, 12:32

  21. core-ci voted on patch set 10 V +1 11/21/21, 12:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19602

  22. Christian Kuhn voted on patch set 10 V +1 CR +1 11/21/21, 12:50

  23. Stefan Bürk voted on patch set 10 V +1 CR +1 11/21/21, 14:18

  24. Christian Kuhn voted on patch set 10 V +2 CR +2 11/21/21, 21:04

  25. Christian Kuhn merged patch set 11 11/21/21, 21:04