Review main Merged

72214[BUGFIX] Initialize inline form fields just once

Oliver Hader CR +2 V +2 Easy +1 −7 updated 11/17/21, 20:30

Commit message

Due to a bug, inline form fields were initialized twice, causing
internal application state issues in FormEngine and Modal handling.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Chris Müller +1
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 68

  1. Oliver Hader uploaded patch set 1 11/17/21, 17:57

  2. core-ci voted on patch set 1 V -1 11/17/21, 18:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19421

  3. Oliver Hader uploaded patch set 2 11/17/21, 18:23

  4. core-ci voted on patch set 2 V +1 11/17/21, 18:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19424

  5. Chris Müller voted on patch set 2 V +1 11/17/21, 19:40

  6. Oli Bartsch voted on patch set 2 V +1 CR +1 11/17/21, 20:09

  7. Oliver Hader voted on patch set 2 V +2 CR +2 11/17/21, 20:30

  8. Oliver Hader merged patch set 3 11/17/21, 20:30