Review 10.4 Merged

72218[TASK] runTests.sh: xdebug trigger works with macOS and WSL2

Christian Kuhn CR +2 V +2 Normal +50 −33 updated 11/17/21, 19:10

Commit message

docker on mac and windows WSL2 encapsulate a VM into
the system. The current xdebug remote config does not
work in those cases since the host IP can not be
determined with the current solution.

Switching to host.docker.internal works for macOS
and WSL2, and works for linux too in combination with
an extra_hosts setting.

This requires linux to use at least docker 20.10,
which shouldn't be a huge issue with casual developer
machines.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 45

  1. Christian Kuhn uploaded patch set 1 11/17/21, 18:41

  2. core-ci voted on patch set 1 V +1 11/17/21, 18:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19426

  3. Stefan Bürk voted on patch set 1 V +1 CR +1 11/17/21, 19:01

  4. Christian Kuhn voted on patch set 1 V +2 CR +2 11/17/21, 19:10

  5. Christian Kuhn merged patch set 2 11/17/21, 19:10