Review main Merged

72219[BUGFIX] Trigger modal dismiss on cancel

Jochen Roth CR +2 V +2 Easy +5 −2 updated 11/22/21, 09:11

Commit message

Currently when a language in site configuration
is removed the modal cancel button does not
remove/cancel the modal.

This has been fixed by adding a trigger to close
the modal when the cancel button was clicked.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 912

  1. Jochen Roth uploaded patch set 1 11/17/21, 19:54

  2. Oli Bartsch voted on patch set 1 V +1 CR +1 11/17/21, 20:03

  3. core-ci voted on patch set 1 V +1 11/17/21, 20:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19431

  4. Georg Ringer updated the commit message in patch set 2 11/18/21, 06:38

  5. core-ci voted on patch set 2 V +1 11/18/21, 06:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19437

  6. Nikita Hovratov voted on patch set 2 V +1 CR +1 11/18/21, 08:28

  7. Benni Mack updated the commit message in patch set 3 11/18/21, 10:50

  8. core-ci voted on patch set 3 V +1 11/18/21, 12:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19485

  9. Oli Bartsch voted on patch set 3 V +1 CR +1 11/19/21, 19:13

  10. Nikita Hovratov voted on patch set 3 V +1 CR +1 11/20/21, 14:53

  11. Oli Bartsch voted on patch set 3 V +2 CR +2 11/22/21, 09:11

  12. Oli Bartsch merged patch set 4 11/22/21, 09:11