Review main Merged

72220[TASK] Relax PackageArtifactBuilder to support PHP 7.1

Simon Gilli CR +2 V +2 Easy +9 −6 updated 11/17/21, 20:43

Commit message

Composer 2.1 supports PHP 5.3 and higher and to avoid issues during the
deployment or on systems where the CLI version is not equal to the FPM
version, the PackageArtifactBuilder is relaxed to also support PHP 7.1
and higher.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Andreas Kienast +1
    • Helmut Hummel +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Helmut Hummel +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1114

  1. Simon Gilli uploaded patch set 1 11/17/21, 20:04

  2. Simon Gilli updated the commit message in patch set 2 11/17/21, 20:08

  3. Simon Gilli commented on patch set 2 11/17/21, 20:08

    This change is ready for review.
  4. core-ci voted on patch set 1 V -1 11/17/21, 20:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19432

  5. core-ci voted on patch set 2 V -1 11/17/21, 20:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19433

  6. Simon Gilli uploaded patch set 3 11/17/21, 20:24

  7. Simon Gilli commented on patch set 3 11/17/21, 20:25

    > Patch Set 1: Verified-1 > > Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19432 Love you too stan 😜
  8. Andreas Kienast voted on patch set 3 CR +1 11/17/21, 20:28

  9. Helmut Hummel voted on patch set 3 V +1 CR +1 11/17/21, 20:37

  10. core-ci voted on patch set 3 V +1 11/17/21, 20:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19434

  11. Georg Ringer voted on patch set 3 V +2 CR +2 11/17/21, 20:42

  12. Georg Ringer voted on patch set 3 V 0 CR +1 11/17/21, 20:42

  13. Oli Bartsch voted on patch set 3 V +2 CR +2 11/17/21, 20:43

  14. Oli Bartsch merged patch set 4 11/17/21, 20:43