Review main Merged

72221[TASK] Avoid inline JavaScript in f:be.menus.actionMenu

Oliver Hader CR +2 V +2 Easy +23 −2 updated 11/18/21, 14:57

Commit message

Uses GlobalEventHandler functionality instead of onchange events.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Torben Hansen +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Torben Hansen +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 912

  1. Oliver Hader uploaded patch set 1 11/18/21, 08:07

  2. Oliver Hader wrote 11/18/21, 08:07

    Topic set to inline-javascript
  3. core-ci voted on patch set 1 V -1 11/18/21, 08:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19438

  4. Oliver Hader uploaded patch set 2 11/18/21, 08:23

  5. core-ci voted on patch set 2 V +1 11/18/21, 08:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19440

  6. Torben Hansen voted on patch set 2 V +1 CR +1 11/18/21, 09:41

  7. Oli Bartsch voted on patch set 2 V +1 CR +1 11/18/21, 10:38

  8. Oliver Hader updated the commit message in patch set 3 11/18/21, 10:50

  9. core-ci voted on patch set 3 V +1 11/18/21, 12:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19484

  10. Torben Hansen voted on patch set 3 V +1 CR +1 11/18/21, 12:40

  11. Oliver Hader voted on patch set 3 V +2 CR +2 11/18/21, 14:57

  12. Oliver Hader merged patch set 4 11/18/21, 14:57