Review main Merged

72222[TASK] Avoid inline JavaScript in wizard EditController

Oliver Hader CR +2 V +2 Normal +49 −2 updated 11/18/21, 19:16

Commit message

Closing a popup window does not use inline JavaScript code anymore.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Torben Hansen +1
  • Verified V +2 Done
    • Benni Mack +2
    • Torben Hansen +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 811

  1. Oliver Hader uploaded patch set 1 11/18/21, 08:07

  2. Oliver Hader wrote 11/18/21, 08:07

    Topic set to inline-javascript
  3. core-ci voted on patch set 1 V -1 11/18/21, 08:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19439

  4. Oliver Hader uploaded patch set 2 11/18/21, 08:27

  5. core-ci voted on patch set 2 V +1 11/18/21, 08:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19441

  6. Torben Hansen voted on patch set 2 V +1 CR +1 11/18/21, 09:31

  7. Oliver Hader updated the commit message in patch set 3 11/18/21, 10:49

  8. core-ci voted on patch set 3 V +1 11/18/21, 12:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19483

  9. Torben Hansen voted on patch set 3 V +1 CR +1 11/18/21, 12:40

  10. Benni Mack voted on patch set 3 V +2 CR +2 11/18/21, 19:16

  11. Benni Mack merged patch set 4 11/18/21, 19:16