Review 11.5 Merged

72227[TASK] Avoid inline JavaScript in wizard EditController

Oliver Hader CR +2 V +2 Normal +49 −2 updated 11/18/21, 19:16

Commit message

Closing a popup window does not use inline JavaScript code anymore.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 46

  1. Oliver Hader uploaded patch set 1 11/18/21, 10:53

  2. core-ci voted on patch set 1 V -1 11/18/21, 12:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19499

  3. Oliver Hader rebased onto patch set 2 11/18/21, 15:06

  4. core-ci voted on patch set 2 V +1 11/18/21, 15:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19518

  5. Benni Mack voted on patch set 2 V +2 CR +2 11/18/21, 19:16

  6. Benni Mack merged patch set 3 11/18/21, 19:16