Review main Merged

72228[BUGFIX] Fix array access for user without read permissions in PHP8

Jochen Roth CR +2 V +2 Easy +1 −1 updated 11/19/21, 21:19

Commit message

Given you have a user which has no access to the current page
or no page at all, a "access array offset on value of type"
is thrown in PHP8.

This has been fixed by adding a fallback in case the
array key does not exist which then throws the expected
exception.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Jochen Roth uploaded patch set 1 11/18/21, 11:10

  2. core-ci voted on patch set 1 V +1 11/18/21, 14:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19501

  3. Oli Bartsch voted on patch set 1 V +1 CR +1 11/19/21, 19:24

  4. Stefan Bürk voted on patch set 1 V +1 CR +1 11/19/21, 21:18

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 11/19/21, 21:18

  6. Christian Kuhn merged patch set 2 11/19/21, 21:19