Review main Merged

72229[BUGFIX] Call extension installer only with extension packages

Helmut Hummel CR +2 V +2 Easy +4 −2 updated 11/18/21, 12:53

Commit message

Calling the TYPO3 extension installer with a root package
of a different type will lead to an exception to be thrown.

Move the install path check after the type check, to be sure
to call the installer only with extension types.

Review

  • Code review CR +2 Done
    • Helmut Hummel +2
    • Georg Ringer +1
    • Simon Gilli +1
    • Benni Mack +1
  • Verified V +2 Done
    • Helmut Hummel +2
    • Georg Ringer +1
    • Simon Gilli +1

Issues 2

Files 1

Review log 79

  1. Helmut Hummel uploaded patch set 1 11/18/21, 12:15

  2. Helmut Hummel uploaded patch set 2 11/18/21, 12:39

  3. Simon Gilli voted on patch set 2 V +1 CR +1 11/18/21, 12:42

  4. Helmut Hummel voted on patch set 2 V +2 CR +2 11/18/21, 12:47

  5. Georg Ringer voted on patch set 2 V +1 CR +1 11/18/21, 12:48

  6. core-ci voted on patch set 1 V +1 11/18/21, 12:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19503

  7. Benni Mack voted on patch set 2 CR +1 11/18/21, 12:52

  8. Helmut Hummel merged patch set 3 11/18/21, 12:52

  9. core-ci voted on patch set 2 V +1 11/18/21, 12:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19506