Review main Merged

72231[BUGFIX] Apply AJAX scriptItems to FormEngine FlexFormSectionContainer

Oliver Hader CR +2 V +2 Easy +7 −2 updated 09/22/22, 13:04

Commit message

When resolving inline JavaScript invocations in issue #95954 it looked
like AJAX-aware elements in FormEngine would share a common abstract
implementation in the client-side handling. Actually AJAX response
handling is independent for each of those elements...

This change now applies changes, that previously have been made to
`TYPO3/CMS/Backend/FormEngine/InlineRelation/AjaxDispatcher`, to
`TYPO3/CMS/Backend/FormEngine/Container/FlexFormSectionContainer`.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jörg Bösche +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jörg Bösche +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 56

  1. Oliver Hader uploaded patch set 1 11/18/21, 12:52

  2. core-ci voted on patch set 1 V +1 11/18/21, 13:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19507

  3. Jörg Bösche commented on patch set 1 V +1 CR +1 11/18/21, 13:08

    Tested and verified with flexform section and standalone item outside of a section. Thank you so much!
  4. Oli Bartsch voted on patch set 1 V +2 CR +2 11/18/21, 13:51

  5. Oli Bartsch merged patch set 2 11/18/21, 13:51

  6. Oliver Hader commented on patch set 2 09/22/22, 13:04

    FormFlexAjaxController.php:189 Unresolved

    Hm... seems like this should have been merged... currently it overrides previous `scriptCall` items as well.