Review main Merged

72234[TASK] More deterministic functional test 'regular' DataSet

Christian Kuhn CR +2 V +2 Hard +491 −491 updated 11/18/21, 19:30

Commit message

The DataHandler 'regular' functional import DataSet
uses a duplicate sorting value for tt_content records
296 and 297.

This is an artificial setup - the DataHandler won't
create this itself.

To make sorting values in tests easier to understand and
follow, the import set is adapted to use distinct sorting
values for these rows. This is a pre-patch to fix a
localization related sorting issue.

In case the "duplicate sorting value" scenario should
be tested, it should receive dedicated tests.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 284

Show 264 more files

Review log 79

  1. Christian Kuhn uploaded patch set 1 11/18/21, 17:22

  2. Christian Kuhn commented on patch set 1 11/18/21, 17:24

    -1 wip, want the same in workspaces.
  3. core-ci voted on patch set 1 V +1 11/18/21, 17:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19526

  4. Christian Kuhn uploaded patch set 2 11/18/21, 18:18

  5. core-ci voted on patch set 2 V +1 11/18/21, 18:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19529

  6. Jochen Roth voted on patch set 2 V +1 CR +1 11/18/21, 19:04

  7. Benni Mack voted on patch set 2 V +1 CR +1 11/18/21, 19:15

  8. Christian Kuhn voted on patch set 2 V +2 CR +2 11/18/21, 19:30

  9. Christian Kuhn merged patch set 3 11/18/21, 19:30