72237[BUGFIX] Properly check permissions for system notes
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 3
Review log 1927
Show 12 earlier messages
-
Jochen Roth uploaded patch set 1 11/18/21, 22:46
-
core-ci voted on patch set 1 V +1 11/18/21, 23:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19536
-
Oli Bartsch commented on patch set 1 11/19/21, 13:11
-
Jochen Roth commented on patch set 1 11/19/21, 19:09
NoteController.php:57ReplyDone -
Jochen Roth uploaded patch set 2 11/19/21, 19:14
-
core-ci voted on patch set 2 V +1 11/19/21, 19:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19572
-
Guido Schmechel commented on patch set 2 11/19/21, 23:11
NoteController.php:77We could use $backendUser tooNoteController.php:83Do we need a docblock like in BackendUserController.php? -
Jochen Roth uploaded patch set 3 11/22/21, 14:37
-
core-ci voted on patch set 3 V +1 11/22/21, 14:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19638
-
Jochen Roth uploaded patch set 4 11/22/21, 16:15
-
Jochen Roth commented on patch set 4 11/22/21, 16:18
Thanks for reviewing :-)NoteController.php:77ReplyAckNoteController.php:83ReplyNot required here because it does not provide additional information. -
core-ci voted on patch set 4 V +1 11/22/21, 16:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19646
-
Oli Bartsch uploaded patch set 5 11/22/21, 20:07
-
core-ci voted on patch set 5 V +1 11/22/21, 20:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19654
-
Oli Bartsch uploaded patch set 6 11/22/21, 21:14
-
core-ci voted on patch set 6 V +1 11/22/21, 21:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19657
-
Jochen Roth voted on patch set 6 V +1 CR +1 11/23/21, 09:26
-
Benni Mack voted on patch set 6 V +1 CR +1 11/27/21, 13:20
-
Christian Kuhn commented on patch set 6 CR -1 11/27/21, 16:52
minor detail.NoteController.php:102stuff like that is typically useless since php garbage collection will do it's magic upon leaving the method. -
Christian Kuhn uploaded patch set 7 11/27/21, 20:58
-
Christian Kuhn commented on patch set 7 11/27/21, 21:01
NoteController.php:102ReplyDone -
Christian Kuhn voted on patch set 7 V +1 CR +1 11/27/21, 21:15
-
Stefan Bürk voted on patch set 7 V +1 CR +1 11/27/21, 21:16
-
core-ci voted on patch set 7 V -1 11/27/21, 21:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19899
-
core-ci voted on patch set 7 V +1 11/27/21, 22:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19899
-
Christian Kuhn voted on patch set 7 V +2 CR +2 11/27/21, 23:04
-
Christian Kuhn merged patch set 8 11/27/21, 23:04
NoteController.php:57