Review main Merged

72237[BUGFIX] Properly check permissions for system notes

Jochen Roth CR +2 V +2 Normal +65 −19 updated 11/27/21, 23:04

Commit message

The NoteController, used to display system notes in a
couple of modules, e.g. page layout, does now properly
check the corresponding user permissions (show/edit/delete).

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1927

Show 12 earlier messages
  1. Jochen Roth uploaded patch set 1 11/18/21, 22:46

  2. core-ci voted on patch set 1 V +1 11/18/21, 23:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19536

  1. Oli Bartsch commented on patch set 1 11/19/21, 13:11

    NoteController.php:57

    Non of the permission checks takes the $note or $key into account. SO either make the checks more detailed or skip the loop.
  2. Jochen Roth commented on patch set 1 11/19/21, 19:09

    NoteController.php:57 Reply

    Done
  3. Jochen Roth uploaded patch set 2 11/19/21, 19:14

  4. core-ci voted on patch set 2 V +1 11/19/21, 19:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19572

  5. Guido Schmechel commented on patch set 2 11/19/21, 23:11

    NoteController.php:77

    We could use $backendUser too

    NoteController.php:83

    Do we need a docblock like in BackendUserController.php?
  6. Jochen Roth uploaded patch set 3 11/22/21, 14:37

  7. core-ci voted on patch set 3 V +1 11/22/21, 14:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19638

  8. Jochen Roth uploaded patch set 4 11/22/21, 16:15

  9. Jochen Roth commented on patch set 4 11/22/21, 16:18

    Thanks for reviewing :-)

    NoteController.php:77 Reply

    Ack

    NoteController.php:83 Reply

    Not required here because it does not provide additional information.
  10. core-ci voted on patch set 4 V +1 11/22/21, 16:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19646

  11. Oli Bartsch uploaded patch set 5 11/22/21, 20:07

  12. core-ci voted on patch set 5 V +1 11/22/21, 20:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19654

  13. Oli Bartsch uploaded patch set 6 11/22/21, 21:14

  14. core-ci voted on patch set 6 V +1 11/22/21, 21:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19657

  15. Jochen Roth voted on patch set 6 V +1 CR +1 11/23/21, 09:26

  16. Benni Mack voted on patch set 6 V +1 CR +1 11/27/21, 13:20

  17. Christian Kuhn commented on patch set 6 CR -1 11/27/21, 16:52

    minor detail.

    NoteController.php:102

    stuff like that is typically useless since php garbage collection will do it's magic upon leaving the method.
  18. Christian Kuhn uploaded patch set 7 11/27/21, 20:58

  19. Christian Kuhn commented on patch set 7 11/27/21, 21:01

    NoteController.php:102 Reply

    Done
  20. Christian Kuhn voted on patch set 7 V +1 CR +1 11/27/21, 21:15

  21. Stefan Bürk voted on patch set 7 V +1 CR +1 11/27/21, 21:16

  22. core-ci voted on patch set 7 V -1 11/27/21, 21:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19899

  23. core-ci voted on patch set 7 V +1 11/27/21, 22:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19899

  24. Christian Kuhn voted on patch set 7 V +2 CR +2 11/27/21, 23:04

  25. Christian Kuhn merged patch set 8 11/27/21, 23:04