72240[TASK] Avoid inline JavaScript in DispatchNotificationHook
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Jochen Roth +1
-
Verified V +2 Done
- Oli Bartsch +2
- Jochen Roth +1
- core-ci +1 CI
Issues 1
Files 5
- Build/Sources/TypeScript/redirects/Resources/Public/TypeScript/EventHandler.ts+5 −0
- typo3/sysext/core/Classes/Page/JavaScriptModuleInstruction.php+23 −0
- typo3/sysext/core/Resources/Public/JavaScript/JavaScriptHandler.js+4 −2
- typo3/sysext/redirects/Classes/Hooks/DispatchNotificationHook.php2+12 −9
- typo3/sysext/redirects/Resources/Public/JavaScript/EventHandler.js+1 −1
Review log 1216
-
Oliver Hader uploaded patch set 1 11/19/21, 09:24
-
core-ci voted on patch set 1 V +1 11/19/21, 09:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19546
-
Oliver Hader rebased onto patch set 2 11/23/21, 10:02
-
Oliver Hader commented on patch set 2 11/23/21, 10:08
-
core-ci voted on patch set 2 V +1 11/23/21, 10:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19666
-
Oliver Hader marked it work in progress 11/23/21, 10:15
-
Oliver Hader uploaded patch set 3 11/23/21, 10:32
-
Oliver Hader commented on patch set 3 11/23/21, 10:32
This change is ready for review. -
Oliver Hader commented on patch set 3 11/23/21, 10:35
DispatchNotificationHook.php:39ReplyDone -
Oliver Hader uploaded patch set 4 11/23/21, 10:37
-
core-ci voted on patch set 3 V +1 11/23/21, 10:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19667
-
core-ci voted on patch set 4 V +1 11/23/21, 10:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19668
-
Jochen Roth voted on patch set 4 V +1 CR +1 11/23/21, 12:35
-
Oli Bartsch voted on patch set 4 V +1 CR +1 11/23/21, 12:36
-
Oli Bartsch voted on patch set 4 V +2 CR +2 11/23/21, 12:38
-
Oli Bartsch merged patch set 5 11/23/21, 12:38
DispatchNotificationHook.php:39