Review main Merged

72240[TASK] Avoid inline JavaScript in DispatchNotificationHook

Oliver Hader CR +2 V +2 Normal +45 −12 updated 11/23/21, 12:38

Commit message

DispatchNotificationHook in ext:redirects has been adjusted
to trigger events using a script-less implementation.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1216

  1. Oliver Hader uploaded patch set 1 11/19/21, 09:24

  2. core-ci voted on patch set 1 V +1 11/19/21, 09:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19546

  3. Oliver Hader rebased onto patch set 2 11/23/21, 10:02

  4. Oliver Hader commented on patch set 2 11/23/21, 10:08

    DispatchNotificationHook.php:39

    Probably the 3rd argument should be replaced by `->addFlags(JavaScriptModuleInstruction::FLAG_USE_TOP_WINDOW)`
  5. core-ci voted on patch set 2 V +1 11/23/21, 10:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19666

  6. Oliver Hader marked it work in progress 11/23/21, 10:15

  7. Oliver Hader uploaded patch set 3 11/23/21, 10:32

  8. Oliver Hader commented on patch set 3 11/23/21, 10:32

    This change is ready for review.
  9. Oliver Hader commented on patch set 3 11/23/21, 10:35

    DispatchNotificationHook.php:39 Reply

    Done
  10. Oliver Hader uploaded patch set 4 11/23/21, 10:37

  11. core-ci voted on patch set 3 V +1 11/23/21, 10:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19667

  12. core-ci voted on patch set 4 V +1 11/23/21, 10:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19668

  13. Jochen Roth voted on patch set 4 V +1 CR +1 11/23/21, 12:35

  14. Oli Bartsch voted on patch set 4 V +1 CR +1 11/23/21, 12:36

  15. Oli Bartsch voted on patch set 4 V +2 CR +2 11/23/21, 12:38

  16. Oli Bartsch merged patch set 5 11/23/21, 12:38