72249[TASK] Ensure tests for extensions work
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Rafael Kähm +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Rafael Kähm +1
- core-ci +1 CI
Issues 1
Files 4
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Transform/HtmlViewHelperTest.php+8 −2
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php3+3 −2
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php3+2 −2
- typo3/sysext/frontend/Classes/Typolink/PageLinkBuilder.php+7 −0
Review log 1014
-
Benni Mack uploaded patch set 1 11/22/21, 13:19
-
Benni Mack uploaded patch set 2 11/22/21, 13:25
-
core-ci voted on patch set 1 V -1 11/22/21, 13:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19630
-
core-ci voted on patch set 2 V -1 11/22/21, 13:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19631
-
Benni Mack uploaded patch set 3 11/22/21, 14:21
-
Benni Mack uploaded patch set 4 11/22/21, 14:22
-
core-ci voted on patch set 3 V +1 11/22/21, 14:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19635
-
core-ci voted on patch set 4 V +1 11/22/21, 14:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19636
-
Rafael Kähm voted on patch set 4 V +1 CR +1 11/23/21, 09:52
-
Oli Bartsch commented on patch set 4 V +1 11/23/21, 10:23
TypoScriptFrontendController.php:3548Could we instead add a "?BackendUserAuthentication" return type? -
Benni Mack commented on patch set 4 11/23/21, 10:25
ContentObjectRenderer.php:6805ReplyI did not want to add type hints to stable LTS.TypoScriptFrontendController.php:3548ReplyI did not want to add type hints to stable LTS. -
Oli Bartsch commented on patch set 4 CR +1 11/23/21, 10:36
ContentObjectRenderer.php:6805ReplyAckTypoScriptFrontendController.php:3548ReplyAck -
Benni Mack voted on patch set 4 V +2 CR +2 11/23/21, 21:14
-
Benni Mack merged patch set 5 11/23/21, 21:14
ContentObjectRenderer.php:6805