Review main Merged

72249[TASK] Ensure tests for extensions work

Benni Mack CR +2 V +2 Easy +20 −6 updated 11/23/21, 21:14

Commit message

This change makes some FE calls easier for testing
in extensions, such as EXT:solr.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Rafael Kähm +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Rafael Kähm +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1014

  1. Benni Mack uploaded patch set 1 11/22/21, 13:19

  2. Benni Mack uploaded patch set 2 11/22/21, 13:25

  3. core-ci voted on patch set 1 V -1 11/22/21, 13:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19630

  4. core-ci voted on patch set 2 V -1 11/22/21, 13:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19631

  5. Benni Mack uploaded patch set 3 11/22/21, 14:21

  6. Benni Mack uploaded patch set 4 11/22/21, 14:22

  7. core-ci voted on patch set 3 V +1 11/22/21, 14:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19635

  8. core-ci voted on patch set 4 V +1 11/22/21, 14:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19636

  9. Rafael Kähm voted on patch set 4 V +1 CR +1 11/23/21, 09:52

  10. Oli Bartsch commented on patch set 4 V +1 11/23/21, 10:23

    ContentObjectRenderer.php:6805

    Could we instead add a "?TypoScriptFrontendController" return type?

    TypoScriptFrontendController.php:3548

    Could we instead add a "?BackendUserAuthentication" return type?
  11. Benni Mack commented on patch set 4 11/23/21, 10:25

    ContentObjectRenderer.php:6805 Reply

    I did not want to add type hints to stable LTS.

    TypoScriptFrontendController.php:3548 Reply

    I did not want to add type hints to stable LTS.
  12. Oli Bartsch commented on patch set 4 CR +1 11/23/21, 10:36

    ContentObjectRenderer.php:6805 Reply

    Ack

    TypoScriptFrontendController.php:3548 Reply

    Ack
  13. Benni Mack voted on patch set 4 V +2 CR +2 11/23/21, 21:14

  14. Benni Mack merged patch set 5 11/23/21, 21:14