Review 11.5 Merged

72258[BUGFIX] Prevent workspace access checks for dummy user

Oli Bartsch CR +2 V +2 Easy +36 −2 updated 11/22/21, 16:30

Commit message

The backend usergroup compare view requires to fetch the
group data of the groups to compare. Since this operation
depends on a user array, UserInformationService creates
such dummy user.

Since #93233 the dummy user array also contains a workspace
id `-99`.

To successfully overcome workspace access-checks, set
the admin-flag for this fake-user. Use workspace uid 0,
to avoid any database operations on workspace access
checks. Workspace 0 additionally prevents the log-message,
which led to the exception message described at #93894.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 2

Files 3

Review log 34

  1. Oli Bartsch commented on patch set 1 11/22/21, 16:12

    Cherry Picked from branch master.
  2. core-ci voted on patch set 1 V +1 11/22/21, 16:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19644

  3. Oli Bartsch voted on patch set 1 V +2 CR +2 11/22/21, 16:30

  4. Oli Bartsch merged patch set 2 11/22/21, 16:30