Review 11.5 Merged

72263[BUGFIX] Add missing checks for translate keys in compare view

Oli Bartsch CR +2 V +2 Easy +12 −6 updated 11/23/21, 20:42

Commit message

The compare view of EXT:beuser does a couple
of f:translate calls with dynamic values as key.
Since some of those calls did not properly check
the provided key, before passing it to the view
helper, this previously led to exceptions.

This is now fixed by properly checking the
key, before passing it to the f:translate
view helper. Additionally, some defaults
are added to support static labels.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Oli Bartsch commented on patch set 1 11/23/21, 20:24

    Cherry Picked from branch master.
  2. core-ci voted on patch set 1 V +1 11/23/21, 20:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19686

  3. Oli Bartsch voted on patch set 1 V +2 CR +2 11/23/21, 20:42

  4. Oli Bartsch merged patch set 2 11/23/21, 20:42