Review main Merged

72273[BUGFIX] Ensure hidden records are filtered out in RootlineUtility

Benni Mack CR +2 V +2 Easy +12 −3 updated 12/01/21, 20:20

Commit message

RelationHandler always returns hidden records as well,
but they will crash when having pages.media with hidden
records.

If running in Frontend, this should not be allowed,
so the hidden restriction comes into effect.

This happens because we now use the RelationHandler
consistently instead of using manual SQL queries since
11.5.3.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 3

Files 2

Review log 1322

  1. Benni Mack uploaded patch set 1 11/22/21, 21:42

  2. core-ci voted on patch set 1 V -1 11/22/21, 21:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19658

  3. Benni Mack uploaded patch set 2 11/27/21, 12:21

  4. core-ci voted on patch set 2 V -1 11/27/21, 12:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19849

  5. Benni Mack uploaded patch set 3 11/28/21, 21:40

  6. core-ci voted on patch set 3 V +1 11/28/21, 21:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19951

  7. Benni Mack wrote 11/29/21, 10:21

    Change destination moved from master to main
  8. Benni Mack updated the commit message in patch set 4 11/29/21, 14:11

  9. core-ci voted on patch set 4 V +1 11/29/21, 18:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20118

  10. Benni Mack updated the commit message in patch set 5 11/30/21, 11:20

  11. Benni Mack updated the commit message in patch set 6 11/30/21, 11:20

  12. core-ci voted on patch set 5 V +1 11/30/21, 11:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20212

  13. core-ci voted on patch set 6 V +1 11/30/21, 11:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20213

  14. Benni Mack updated the commit message in patch set 7 12/01/21, 10:35

  15. core-ci voted on patch set 7 V -1 12/01/21, 10:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20300

  16. core-ci voted on patch set 7 V +1 12/01/21, 10:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20300

  17. Benni Mack updated the commit message in patch set 8 12/01/21, 13:20

  18. core-ci voted on patch set 8 V +1 12/01/21, 13:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20316

  19. Oli Bartsch voted on patch set 8 V +1 CR +1 12/01/21, 14:32

  20. Stefan Bürk voted on patch set 8 V +1 CR +1 12/01/21, 20:17

  21. Benni Mack voted on patch set 8 V +2 CR +2 12/01/21, 20:20

  22. Benni Mack merged patch set 9 12/01/21, 20:20