72276[BUGFIX] Do not use hardcoded field name for belayoutwizard
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Jochen Roth +1
- Nikita Hovratov +1
- Benni Mack +1
-
Verified V +2 Done
- Oli Bartsch +2
- Jochen Roth +1
- Nikita Hovratov +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1012
-
Oli Bartsch uploaded patch set 1 11/23/21, 19:05
-
core-ci voted on patch set 1 V -1 11/23/21, 19:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19685
-
Oli Bartsch commented on patch set 1 11/23/21, 20:11
Currently failing due to wrong default value in tx_styleguide_elements_basic.text_20. See https://github.com/TYPO3/styleguide/pull/246 -
Oli Bartsch uploaded patch set 2 11/23/21, 22:25
-
core-ci voted on patch set 2 V +1 11/23/21, 22:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19688
-
Oli Bartsch commented on patch set 2 11/23/21, 22:50
Reply
Added some checks to prevent those warnings, in case malformed default values are configured. Anyways, styleguide needs to be updated to provide a valid example. -
Jochen Roth voted on patch set 2 V +1 CR +1 11/24/21, 13:21
-
Benni Mack voted on patch set 2 V +1 CR +1 11/24/21, 16:38
-
Nikita Hovratov commented on patch set 2 V +1 CR +1 11/24/21, 17:33
This enables now editing custom be-layout fields, nice! But there is another issue: Default -
Nikita Hovratov commented on patch set 2 11/24/21, 17:34
Reply
Nvm the TCA in styleguide was wrong. -
Oli Bartsch voted on patch set 2 V +2 CR +2 11/24/21, 18:36
-
Oli Bartsch merged patch set 3 11/24/21, 18:36