Review main Merged

72277[BUGFIX] Observe GridEditor visibility to refresh codeMirror

Oli Bartsch CR +2 V +2 Easy +22 −1 updated 11/24/21, 18:34

Commit message

In case a TCA field with renderType=belayoutwizard
is configured to be not in the initially visible tab, the
CodeMirror editor remains empty, when switching to
the tab, containing the editor. The reason is, CodeMirror
needs to be refreshed, after becoming visible.

Therefore, the GridEditor, holding the configuration,
is now observed, if not initially visible. As soon as it
becomes visible, the CodeMirror instance - if any -
is refreshed.

Can be tested with `tx_styleguide_elements_basic.text_20`.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Nikita Hovratov +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Nikita Hovratov +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 67

  1. Oli Bartsch uploaded patch set 1 11/23/21, 22:48

  2. core-ci voted on patch set 1 V +1 11/23/21, 23:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19689

  3. Jochen Roth voted on patch set 1 V +1 CR +1 11/24/21, 13:05

  4. Nikita Hovratov commented on patch set 1 V +1 CR +1 11/24/21, 16:28

    Nice solution.
  5. Benni Mack voted on patch set 1 V +1 CR +1 11/24/21, 16:38

  6. Oli Bartsch voted on patch set 1 V +2 CR +2 11/24/21, 18:34

  7. Oli Bartsch merged patch set 2 11/24/21, 18:34