Review main Merged

72278[BUGFIX] Make belayoutwizard TSconfig preview readonly

Oli Bartsch CR +2 V +2 Easy +1 −1 updated 11/24/21, 18:37

Commit message

With #94222, the TSconfig preview of a TCA field with
renderType= belayoutwizard was adjusted to use the
CodeMirror plugin - in case EXT:t3editor is installed.

With this change, also the default "preview" was changed
form a <code> element to a <textarea>. This therefore led
to the field being editable. However, any manual change
will always be overwritten on adjusting the grid via the editor
or on saving the record.

To avoid confusion for the user and to be in line with
the CodeMirror variant, the previous behaviour is restored
by adding the readonly attribute to the <textarea> element.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Nikita Hovratov +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Nikita Hovratov +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 67

  1. Oli Bartsch uploaded patch set 1 11/23/21, 23:09

  2. core-ci voted on patch set 1 V +1 11/23/21, 23:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19690

  3. Benni Mack voted on patch set 1 V +1 CR +1 11/24/21, 08:05

  4. Jochen Roth voted on patch set 1 V +1 CR +1 11/24/21, 12:46

  5. Nikita Hovratov voted on patch set 1 V +1 CR +1 11/24/21, 17:42

  6. Oli Bartsch voted on patch set 1 V +2 CR +2 11/24/21, 18:37

  7. Oli Bartsch merged patch set 2 11/24/21, 18:37